在 2025/2/20 17:12, Maxime Ripard 写道:
On Thu, Feb 20, 2025 at 04:53:58PM +0800,oushixiong1...@163.com wrote:
From: Shixiong Ou<oushixi...@kylinos.cn>
[WHY] If the call to sysfs_create_group() fails, there is
no need to call function sysfs_remove_group().
[HOW] Add a condition check before removing sysfs attribute.
Signed-off-by: Shixiong Ou<oushixi...@kylinos.cn>
What are you trying to fix exactly? AFAIK, there's no code path that
calls komeda_dev_destroy() after komeda_dev_create() has failed.
Maxime
|if calling |||sysfs_create_group() fails, it will go to lable 'err_cleanup:', and it
will call |komeda_dev_destroy() laterly. thanks, Shixiong Ou. |
