On Tue, 25 Mar 2025 13:24:12 -0400
Anusha Srivatsa <asriv...@redhat.com> wrote:
> Start using the new helper that does the refcounted
> allocations.
>
> Signed-off-by: Anusha Srivatsa <asriv...@redhat.com>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c
> b/drivers/gpu/drm/panel/panel-simple.c
> index
> 6ba600f97aa4c8daae577823fcf17ef31b0eb46f..60b845fad4e1b378af52d34dfae0139c4625dc51
> 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -579,7 +579,8 @@ static int panel_simple_probe(struct device *dev, const
> struct panel_desc *desc)
> u32 bus_flags;
> int err;
>
> - panel = devm_kzalloc(dev, sizeof(*panel), GFP_KERNEL);
> + panel = devm_drm_panel_alloc(dev, struct panel_simple, base,
> + &panel_simple_funcs, desc->connector_type);
> if (!panel)
> return -ENOMEM;
devm_drm_panel_alloc() returns "Pointer to new panel, or ERR_PTR on
failure.", so you need IS_ERR() to check for an error condition:
if (IS_ERR(panel))
return PTR_ERR(Panel);
Otherwise looks good.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
