On Thu, Apr 03, 2025 at 04:28:22PM +0200, Krzysztof Kozlowski wrote:
> On 03/04/2025 12:31, Marcus Folkesson wrote:
> >>> + i2c {
> >>> + #address-cells = <1>;
> >>> + #size-cells = <0>;
> >>> +
> >>> + display@3f {
> >>
> >> Look how this is called in other bindings... The binding and example are
> >> not following existing code. Why? Why doing something entirely
> >> different?
> >
> > Sorry, I'm not sure what you mean here.
> You added code entirely different than existing code. Why doing
> something entirely different? Open any other panel and look how it is
> called.This is still unclear to me. I assume you are referring to the display@3f? I can see many other panels use display@<address>, e.g. elgin,jg10309-01.yaml and sitronix,st7735r.yaml Those are using address 0, but that is because they are SPI devices, this is a I2C device and address 0 is not valid. There are plenty of examples of I2C devices using the real addresses in the node name. Or do you want me to call it panel@3f ? I can go with that if it is preferred. > > Best regards, > Krzysztof Best regards, Marcus Folkesson
signature.asc
Description: PGP signature
