On 04/04/2025 15:50, Marcus Folkesson wrote: > Sitronix ST7571 is a 4bit gray scale dot matrix LCD controller. > > Signed-off-by: Marcus Folkesson <marcus.folkes...@gmail.com> > --- > .../bindings/display/sitronix,st7571.yaml | 73 > ++++++++++++++++++++++ > 1 file changed, 73 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/sitronix,st7571.yaml > b/Documentation/devicetree/bindings/display/sitronix,st7571.yaml > new file mode 100644 > index > 0000000000000000000000000000000000000000..11575b820c59c5ada427fbb6b015c331215c8db6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/sitronix,st7571.yaml > @@ -0,0 +1,73 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/sitronix,st7571.yaml#
Why isn't this in panels directory? > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sitronix ST7571 Display Panels > + > +maintainers: > + - Marcus Folkesson <marcus.folkes...@gmail.com> > + > +description: > + This binding is for display panels using a Sitronix ST7571 controller in > I2C Do not explain for a binding that it is a binding. Redundant. Instead describe the hardware. > + mode. > + > +allOf: > + - $ref: panel/panel-common.yaml# > + > +properties: > + compatible: > + const: sitronix,st7571 > + > + reg: true > + reset-gpios: true > + width-mm: true > + height-mm: true > + > + panel-timing: > + $ref: panel/panel-timing.yaml# Drop, already part of panel. > + description: | > + The panel-timing node specifies the display resolution and timing > + parameters. The hactive and vactive properties are mandatory. > + The vback-porch property specifies the start line of the display. > + The other properties should be set to zero. Drop description as well. > + > +required: > + - compatible > + - reg > + - reset-gpios > + - width-mm > + - height-mm > + - panel-timing > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + display@3f { Not much improved. How is this called in every other binding? panel. > + compatible = "sitronix,st7571"; Messed indentation. > + reg = <0x3f>; > + reset-gpios = <&gpio0 3 GPIO_ACTIVE_LOW>; > + width-mm = <37>; > + height-mm = <27>; > + > + panel-timing { And here is even more confusing. Best regards, Krzysztof
