Hi Jagath,
On 21/04/25 05:59, Jagath Jog J wrote:
This patch updates the MIPI DBI driver to use drm_device.debugfs_root
instead of drm_minor for creating debugfs files. The debugfs setup is now
done earlier in probe(), before drm_dev_register(), and the drivers can
avoid using the .debugfs_init callback.
This is an initial version, and only a few drivers are updated for now.
I noticed that some newer drivers or patches still use
drm_debugfs_create_files(), which relies on drm_minor. I was wondering if
there is a specific reason for this, or if there's a plan to switch to
drm_debugfs_add_files? I can send patches to update more drivers if
that helps.
Yes, there was a plan to switch to drm_debugfs_add_files(), as it
centers the debugfs files management on the drm_device instead of
drm_minor.
But, in the end, we concluded that we needed a few more changes in the
infrastructure to make things more generic. Here are some discussions
[1][2] and this was my plan to make things more generic [3], which
needed some improvements.
It would be create if you help us to cleanup debugfs and feel free to
use my patches as a base for it.
[1]
https://lore.kernel.org/dri-devel/20230209081838.45273-1-christian.koe...@amd.com/
[2] https://lore.kernel.org/dri-devel/87eds0gm9b....@intel.com/
[3]
https://lore.kernel.org/dri-devel/20230131195825.677487-1-mca...@igalia.com/
Best Regards,
- Maíra
This patch helps move toward the debugfs cleanup task listed here:
https://docs.kernel.org/gpu/todo.html#clean-up-the-debugfs-support
Looking forward to your feedback.
Jagath Jog J (1):
drm/mipi-dbi: Use drm_device for debugfs, drop drm_minor and
.debugfs_init
drivers/gpu/drm/drm_mipi_dbi.c | 8 ++++----
drivers/gpu/drm/tiny/ili9163.c | 3 ++-
drivers/gpu/drm/tiny/panel-mipi-dbi.c | 3 ++-
include/drm/drm_mipi_dbi.h | 4 ++--
4 files changed, 10 insertions(+), 8 deletions(-)
