On Wed, Apr 23, 2025 at 03:03:02PM +0530, Ayushi Makhija wrote: > On 4/17/2025 4:14 PM, Dmitry Baryshkov wrote: > > On Thu, Apr 17, 2025 at 11:09:08AM +0530, Ayushi Makhija wrote: > >> From: Ayushi Makhija <quic_amakh...@quicinc.com> > >> > >> In the anx7625_sink_detect(), the device is checked to see > >> if it is a panel bridge, and it always sends a "connected" > >> status to the connector. When adding the DP port on port 1 of the > >> anx7625, it incorrectly treats it as a panel bridge and sends an > >> always "connected" status. Instead of checking the status on the > >> panel bridge, it's better to check the hpd_status for connectors > >> that supports hot-plugging. This way, it verifies the hpd_status > >> variable before sending the status to the connector. > > > > Does this work if the Analogix bridge is connected to an eDP panel? In > > such a case it should report 'connected' even before powering up the > > panel (which might mean HPD pin being low). > > > > Hi Dmitry, > > Thanks for the review. > > In case of eDP, anx7625_bridge_detect() will not get called, because this > below condition > in anx7625_link_bridge() will not get satisfy. anx7625_sink_detect() is > getting called from > anx7625_bridge_detect().
Please mention this in the commit message. With that fixed, LGTM. -- With best wishes Dmitry
