On 29/04/2025 23:33, Barnabás Czémán wrote:
Add driver for BOE TD4320 DSI panel, used in Xiaomi Redmi Note 7
mobile phone.

Signed-off-by: Barnabás Czémán <barnabas.cze...@mainlining.org>
---
  drivers/gpu/drm/panel/Kconfig            |   9 ++
  drivers/gpu/drm/panel/Makefile           |   1 +
  drivers/gpu/drm/panel/panel-boe-td4320.c | 247 +++++++++++++++++++++++++++++++
  3 files changed, 257 insertions(+)

<snip>

+
+       ctx->dsi = dsi;
+       mipi_dsi_set_drvdata(dsi, ctx);
+
+       dsi->lanes = 4;
+       dsi->format = MIPI_DSI_FMT_RGB888;
+       dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
+                         MIPI_DSI_CLOCK_NON_CONTINUOUS;
+
+       drm_panel_init(&ctx->panel, dev, &boe_td4320_panel_funcs,
+                      DRM_MODE_CONNECTOR_DSI);

Please switch to devm_drm_panel_alloc()

+       ctx->panel.prepare_prev_first = true;
+
+       ret = drm_panel_of_backlight(&ctx->panel);
+       if (ret)
+               return dev_err_probe(dev, ret, "Failed to get backlight\n");
+
+       drm_panel_add(&ctx->panel);
+
+       ret = mipi_dsi_attach(dsi);
+       if (ret < 0) {
+               drm_panel_remove(&ctx->panel);
+               return dev_err_probe(dev, ret, "Failed to attach to DSI 
host\n");
+       }
+
+       return 0;
+}
+
+static void boe_td4320_remove(struct mipi_dsi_device *dsi)
+{
+       struct boe_td4320 *ctx = mipi_dsi_get_drvdata(dsi);
+       int ret;
+
+       ret = mipi_dsi_detach(dsi);
+       if (ret < 0)
+               dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret);
+
+       drm_panel_remove(&ctx->panel);
+}
+
+static const struct of_device_id boe_td4320_of_match[] = {
+       { .compatible = "boe,td4320" },
+       { /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, boe_td4320_of_match);
+
+static struct mipi_dsi_driver boe_td4320_driver = {
+       .probe = boe_td4320_probe,
+       .remove = boe_td4320_remove,
+       .driver = {
+               .name = "panel-boe-td4320",
+               .of_match_table = boe_td4320_of_match,
+       },
+};
+module_mipi_dsi_driver(boe_td4320_driver);
+
+MODULE_AUTHOR("Barnabas Czeman <barnabas.cze...@mainlining.org>");
+MODULE_DESCRIPTION("DRM driver for boe td4320 fhdplus video mode dsi panel");
+MODULE_LICENSE("GPL");


Otherwise it looks fine.

Thanks,
Neil

Reply via email to