On 08/05/2025 14:54, Linus Walleij wrote:
> (...)
>> +static int novatek_nt37801_on(struct novatek_nt37801 *ctx)
>> +{
>> + struct mipi_dsi_device *dsi = ctx->dsi;
>> + struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi };
>> +
>> + dsi->mode_flags |= MIPI_DSI_MODE_LPM;
>> +
>> + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0,
>> + 0x55, 0xaa, 0x52, 0x08, 0x01);
>
> The above is obviously some kind of unlocking
> sequence to open page 1 of some vendor registers.
>
> We know this because the exact same sequence appear in
> panel-innolux-p079zca.c and panel-sony-tulip-truly-nt35521.c
> and the last argument is the page, so there we added
> a switch page macro making it clear what is going on.
> Could you do the same here?
I don't have docs and this is auto-generated panel driver based on
downstream DTS, but sure, I can prepare something similar based on above
assumption.
>
> With this addressed:
> Reviewed-by: Linus Walleij <linus.wall...@linaro.org>
>
> Yours,
> Linus Walleij
Best regards,
Krzysztof
