On 2025-05-08 09:38, Murthy, Arun R wrote: >> -----Original Message----- >> From: Alex Deucher <alexdeuc...@gmail.com> >> Sent: Wednesday, April 23, 2025 8:51 PM >> To: Borah, Chaitanya Kumar <chaitanya.kumar.bo...@intel.com>; Wentland, >> Harry <harry.wentl...@amd.com>; Leo (Sunpeng) Li <sunpeng...@amd.com> >> Cc: Murthy, Arun R <arun.r.mur...@intel.com>; dri- >> de...@lists.freedesktop.org; intel-...@lists.freedesktop.org; intel- >> x...@lists.freedesktop.org; alexander.deuc...@amd.com; Jani Nikula >> <jani.nik...@linux.intel.com>; Syrjala, Ville <ville.syrj...@intel.com>; >> Ville >> Syrjälä <ville.syrj...@linux.intel.com>; Kumar, Naveen1 >> <naveen1.ku...@intel.com> >> Subject: Re: [PATCH RESEND v13 0/5] Expose modifiers/formats supported by >> async flips >> >> + Harry and Leo
I didn't go through the set thoroughly but had a look at patches 1 and 2. It looks like it's simply a copy of IN_FORMATS for async flips, which makes sense to me. Patches 1 and 2 are Acked-by: Harry Wentland <harry.wentl...@amd.com> Harry >> >> On Wed, Apr 16, 2025 at 2:33 AM Borah, Chaitanya Kumar >> <chaitanya.kumar.bo...@intel.com> wrote: >>> >>> Hello Alexander, >>> >>>> -----Original Message----- >>>> From: Murthy, Arun R <arun.r.mur...@intel.com> >>>> Sent: Monday, April 7, 2025 11:14 AM >>>> To: dri-devel@lists.freedesktop.org; >>>> intel-...@lists.freedesktop.org; intel- x...@lists.freedesktop.org >>>> Cc: Jani Nikula <jani.nik...@linux.intel.com>; Borah, Chaitanya >>>> Kumar <chaitanya.kumar.bo...@intel.com>; Syrjala, Ville >>>> <ville.syrj...@intel.com>; Murthy, Arun R <arun.r.mur...@intel.com>; >>>> Ville Syrjälä <ville.syrj...@linux.intel.com>; Kumar, Naveen1 >>>> <naveen1.ku...@intel.com> >>>> Subject: [PATCH RESEND v13 0/5] Expose modifiers/formats supported >>>> by async flips >>>> >>>> All of the formats/modifiers supported by the plane during >>>> synchronous flips are nor supported by asynchronous flips. The >>>> formats/modifiers exposed to user by IN_FORMATS exposes all >>>> formats/modifiers supported by plane and this list varies for async >>>> flips. If the async flip supported formats/modifiers are exposed to >>>> the user, user based on this list can take decision to proceed or not and >> avoid flip failures during async flips. >>>> Discussion around this can be located @ >>>> https://gitlab.freedesktop.org/mesa/mesa/- >>>> /merge_requests/29618#note_2487123 >>>> Mutter implementation for IN_FORMARTS_ASYNC under review @ >>>> https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/4063 >>>> Xorg/modesetting patch >>>> https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1816 >>>> >>> >>> We have added a new drm plane property to expose the format modifier pairs >> supported by a plane for async flip. >>> Can you please let us know if this implementation looks good to you? If so, >> kindly provide an Ack. >>> >>> IGT implementation: https://patchwork.freedesktop.org/series/146853/ >> >> Seems reasonable to me, but I'm not as involved in the display side anymore. >> I'd defer to Harry and Leo. @Wentland, Harry, @Leo >> (Sunpeng) Li can you take a look? >> > If no other comments on this, can we go ahead with the merge given that we > have ACK from the following user space implementation also. > Mutter implementation > https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/4063 > Xorg Implementation > https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1816 > KDE Kwin Implementation: > https://invent.kde.org/plasma/kwin/-/merge_requests/7277 > IGT implementation: > https://patchwork.freedesktop.org/series/146853/ > > Thanks and Regards, > Arun R Murthy > --------------------
