On Thu, May 8, 2025 at 6:40 AM Philipp Stanner <pha...@mailbox.org> wrote: > > On Wed, 2025-04-23 at 14:06 +0200, Philipp Stanner wrote: > > vmgfx enables its PCI device with pcim_enable_device(). This, > > implicitly, switches the function pci_request_regions() into managed > > mode, where it becomes a devres function. > > > > The PCI subsystem wants to remove this hybrid nature from its > > interfaces. To do so, users of the aforementioned combination of > > functions must be ported to non-hybrid functions. > > > > Moreover, since both functions are already managed in this driver, > > the > > calls to pci_release_regions() are unnecessary. > > > > Remove the calls to pci_release_regions(). > > > > Replace the call to sometimes-managed pci_request_regions() with one > > to > > the always-managed pcim_request_all_regions(). > > > > Signed-off-by: Philipp Stanner <pha...@kernel.org> > > *PING*
Thanks, that looks great. I missed it because the driver's name is vmwgfx. I'd be happy to fix the subject for you while pushing this to drm-misc-fixes, if you're ok with it of course. Otherwise: Reviewed-by: Zack Rusin <zack.ru...@broadcom.com> z
smime.p7s
Description: S/MIME Cryptographic Signature
