From: Fiona Behrens <m...@kloenk.dev> Generate the `rust_helper_read{b,w,l,q}`, `rust_helper_write{b,w,l,q}` and the relaxed version using a C macro.
This removes a lot of redundant code and is in preparation for pio functions which uses a similar C macro. Signed-off-by: Fiona Behrens <m...@kloenk.dev> Signed-off-by: Andrew Ballance <andrewjballa...@gmail.com> --- rust/helpers/io.c | 104 +++++++++++++--------------------------------- 1 file changed, 28 insertions(+), 76 deletions(-) diff --git a/rust/helpers/io.c b/rust/helpers/io.c index 15ea187c5466..525af02f209e 100644 --- a/rust/helpers/io.c +++ b/rust/helpers/io.c @@ -12,90 +12,42 @@ void rust_helper_iounmap(void __iomem *addr) iounmap(addr); } -u8 rust_helper_readb(const void __iomem *addr) -{ - return readb(addr); -} - -u16 rust_helper_readw(const void __iomem *addr) -{ - return readw(addr); -} - -u32 rust_helper_readl(const void __iomem *addr) -{ - return readl(addr); -} - +#define define_rust_mmio_read_helper(name, type) \ + type rust_helper_##name(void __iomem *addr) \ + { \ + return name(addr); \ + } + +#define define_rust_mmio_write_helper(name, type) \ + void rust_helper_##name(type value, void __iomem *addr) \ + { \ + name(value, addr); \ + } + +define_rust_mmio_read_helper(readb, u8); +define_rust_mmio_read_helper(readw, u16); +define_rust_mmio_read_helper(readl, u32); #ifdef CONFIG_64BIT -u64 rust_helper_readq(const void __iomem *addr) -{ - return readq(addr); -} +define_rust_mmio_read_helper(readq, u64); #endif -void rust_helper_writeb(u8 value, void __iomem *addr) -{ - writeb(value, addr); -} - -void rust_helper_writew(u16 value, void __iomem *addr) -{ - writew(value, addr); -} - -void rust_helper_writel(u32 value, void __iomem *addr) -{ - writel(value, addr); -} - +define_rust_mmio_write_helper(writeb, u8); +define_rust_mmio_write_helper(writew, u16); +define_rust_mmio_write_helper(writel, u32); #ifdef CONFIG_64BIT -void rust_helper_writeq(u64 value, void __iomem *addr) -{ - writeq(value, addr); -} +define_rust_mmio_write_helper(writeq, u64); #endif -u8 rust_helper_readb_relaxed(const void __iomem *addr) -{ - return readb_relaxed(addr); -} - -u16 rust_helper_readw_relaxed(const void __iomem *addr) -{ - return readw_relaxed(addr); -} - -u32 rust_helper_readl_relaxed(const void __iomem *addr) -{ - return readl_relaxed(addr); -} - +define_rust_mmio_read_helper(readb_relaxed, u8); +define_rust_mmio_read_helper(readw_relaxed, u16); +define_rust_mmio_read_helper(readl_relaxed, u32); #ifdef CONFIG_64BIT -u64 rust_helper_readq_relaxed(const void __iomem *addr) -{ - return readq_relaxed(addr); -} +define_rust_mmio_read_helper(readq_relaxed, u64); #endif -void rust_helper_writeb_relaxed(u8 value, void __iomem *addr) -{ - writeb_relaxed(value, addr); -} - -void rust_helper_writew_relaxed(u16 value, void __iomem *addr) -{ - writew_relaxed(value, addr); -} - -void rust_helper_writel_relaxed(u32 value, void __iomem *addr) -{ - writel_relaxed(value, addr); -} - +define_rust_mmio_write_helper(writeb_relaxed, u8); +define_rust_mmio_write_helper(writew_relaxed, u16); +define_rust_mmio_write_helper(writel_relaxed, u32); #ifdef CONFIG_64BIT -void rust_helper_writeq_relaxed(u64 value, void __iomem *addr) -{ - writeq_relaxed(value, addr); -} +define_rust_mmio_write_helper(writeq_relaxed, u64); #endif -- 2.49.0