Thanks for your reply Alex,
I just realize with your comment that
*drivers/gpu/drm/amd/display/dc/gpio/hw_gpio.c* import *dal_hw_gpio_get_value
*and *dal_hw_gpio_set_value*.
So to make those functions inside
*drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c* more clear what do you
think to change them to *dal_hw_hpd_get_config* and *dal_hw_hpd_set_config*,
making clear that this is a function from the file hw_hpd?
Leonardo Gomes
Em qua., 14 de mai. de 2025 às 18:08, Alex Deucher <alexdeuc...@gmail.com>
escreveu:
> On Wed, May 14, 2025 at 4:48 PM Leonardo Gomes
> <leonardodasigo...@gmail.com> wrote:
> >
> > Adjust get_value function in hw_hpd.c file to have
> > prefix to help in ftrace, the name change from
> > 'get_value' to 'dal_hw_gpio_get_value'
>
> This won't compile. dal_hw_gpio_get_value is already defined in
> drivers/gpu/drm/amd/display/dc/gpio/hw_gpio.c.
>
> Alex
>
> >
> > Signed-off-by: Leonardo da Silva Gomes <leonardodasigo...@gmail.com>
> > Co-developed-by: Derick Frias <derick.william.mor...@gmail.com>
> > Signed-off-by: Derick Frias <derick.william.mor...@gmail.com>
> > ---
> > drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c
> b/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c
> > index 3f13a744d07d..b11ed1089589 100644
> > --- a/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c
> > +++ b/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c
> > @@ -62,7 +62,7 @@ static void dal_hw_hpd_destroy(
> > *ptr = NULL;
> > }
> >
> > -static enum gpio_result get_value(
> > +static enum gpio_result dal_hw_gpio_get_value(
> > const struct hw_gpio_pin *ptr,
> > uint32_t *value)
> > {
> > @@ -104,7 +104,7 @@ static enum gpio_result set_config(
> > static const struct hw_gpio_pin_funcs funcs = {
> > .destroy = dal_hw_hpd_destroy,
> > .open = dal_hw_gpio_open,
> > - .get_value = get_value,
> > + .get_value = dal_hw_gpio_get_value,
> > .set_value = dal_hw_gpio_set_value,
> > .set_config = set_config,
> > .change_mode = dal_hw_gpio_change_mode,
> > --
> > 2.43.0
> >
>
