On Fri, May 16, 2025 at 6:52 PM Ryan Walklin <r...@testtoast.com> wrote: > > From: Jernej Skrabec <jernej.skra...@gmail.com> > > The DE33 is a newer version of the Allwinner Display Engine IP block, > found in the H616, H618, H700 and T507 SoCs. DE2 and DE3 are already > supported by the mainline driver. > > Notable features (from the H616 datasheet and implemented): > - 4096 x 2048 (4K) output support > > Other features (implemented but not in this patchset): > - AFBC ARM Frame Buffer Compression support > - YUV pipeline support > > The DE2 and DE3 engines have a blender register range within the > mixer engine register map, whereas the DE33 separates this out into > a separate display group, and adds a top register map. > > The DE33 also appears to remove the global double buffer control > register, present in the DE2 and DE3. > > Extend the mixer to support the DE33. > > Signed-off-by: Jernej Skrabec <jernej.skra...@gmail.com> > Signed-off-by: Ryan Walklin <r...@testtoast.com> > Signed-off-by: Chris Morgan <macromor...@hotmail.com> > Acked-by: Maxime Ripard <mrip...@kernel.org>
Reviewed-by: Chen-Yu Tsai <w...@csie.org> Code looks OK, though I have not tried to check the register offsets.
