> -----Original Message----- > From: Simon Ser <cont...@emersion.fr> > Sent: Thursday, May 22, 2025 3:45 PM > To: Harry Wentland <harry.wentl...@amd.com> > Cc: Xaver Hugl <xaver.h...@gmail.com>; Alex Hung <alex.h...@amd.com>; dri- > de...@lists.freedesktop.org; amd-...@lists.freedesktop.org; wayland- > de...@lists.freedesktop.org; leo....@amd.com; ville.syrj...@linux.intel.com; > pekka.paala...@collabora.com; m...@igalia.com; jad...@redhat.com; > sebastian.w...@redhat.com; shashank.sha...@amd.com; ago...@nvidia.com; > jos...@froggi.es; mdaen...@redhat.com; aleix...@kde.org; > victo...@system76.com; dan...@ffwll.ch; Shankar, Uma > <uma.shan...@intel.com>; quic_nas...@quicinc.com; > quic_cbr...@quicinc.com; quic_abhin...@quicinc.com; mar...@marcan.st; > liviu.du...@arm.com; sashamcint...@google.com; Borah, Chaitanya Kumar > <chaitanya.kumar.bo...@intel.com>; louis.chau...@bootlin.com > Subject: Re: [PATCH V8 40/43] drm/colorop: Add 3D LUT support to color > pipeline > > On Wednesday, May 21st, 2025 at 21:18, Harry Wentland > <harry.wentl...@amd.com> wrote: > > > On 2025-05-20 16:13, Harry Wentland wrote: > > > > > On 2025-05-19 19:43, Simon Ser wrote: > > > > > > > On Sunday, May 18th, 2025 at 00:32, Xaver Hugl xaver.h...@gmail.com > wrote: > > > > > > > > > > We can always make the property mutable on drivers that > > > > > > support it in > > > > > > > > > > > the future, much like the zpos property. I think we should > > > > > > keep it immutable for now. > > > > > > > > > > Sure, but I don't see any reason for immutability with an enum > > > > > property - it can just limit the possible values to what it > > > > > supports, and that can be only one value. Either way, it's not a big > > > > > issue. > > > > > > > > Immutability is a clear indication that a property has a fixed > > > > read-only value which can't be switched by user-space. That's also > > > > the pattern used everywhere in the KMS uAPI, so I think it's > > > > better to remain consistent here. > > > > > > I was envisioning this to be a driver-caps thing, but I agree if we > > > make this mutable it can still serve that function but with > > > different/future HW possibly support other interpolation schemes. > > > > Would changing this enum property from IMMUTABLE to MUTABLE in the > > future (for drivers that support multiple types) break any userspace > > that assumes IMMUTABLE? > > I don't think it would, see the zpos property.
I agree, should be ok as long as driver supports. Doesn't break any UAPI contract here. Regards, Uma Shankar
