On Thu, May 22, 2025 at 1:52 PM Christian König
<christian.koe...@amd.com> wrote:
>
> On 5/22/25 08:56, Jens Wiklander wrote:
> > On Wed, May 21, 2025 at 9:13 AM Christian König
> > <christian.koe...@amd.com> wrote:
> >>
> >> On 5/20/25 17:16, Jens Wiklander wrote:
> >>> Export the dma-buf heap functions declared in <linux/dma-heap.h>.
> >>
> >> That is what this patch does and that should be obvious by looking at it.
> >> You need to explain why you do this.
> >>
> >> Looking at the rest of the series it's most likely ok, but this commit
> >> message should really be improved.
> >
> > I'm considering something like this for the next version:
> > Export the dma-buf heap functions declared in <linux/dma-heap.h> to allow
> > them to be used by kernel modules. This will enable drivers like the OP-TEE
> > driver, to utilize these interfaces for registering and managing their
> > specific DMA heaps.
>
> Works for me, but it doesn't needs to be so detailed.
>
> Something like this here would be optimal I think:
>
> Export the dma-buf heap functions to allow them to be used by the OP-TEE
> driver.
> The OP-TEE driver wants to register and manage specific secure DMA heaps with
> it.
Great, I'll use that.
Thanks,
Jens
>
> Regards,
> Christian.
>
> >
> > Thanks,
> > Jens
> >
> >>
> >> Regards,
> >> Christian.
> >>
> >>>
> >>> Signed-off-by: Jens Wiklander <jens.wiklan...@linaro.org>
> >>> ---
> >>> drivers/dma-buf/dma-heap.c | 3 +++
> >>> 1 file changed, 3 insertions(+)
> >>>
> >>> diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c
> >>> index 3cbe87d4a464..cdddf0e24dce 100644
> >>> --- a/drivers/dma-buf/dma-heap.c
> >>> +++ b/drivers/dma-buf/dma-heap.c
> >>> @@ -202,6 +202,7 @@ void *dma_heap_get_drvdata(struct dma_heap *heap)
> >>> {
> >>> return heap->priv;
> >>> }
> >>> +EXPORT_SYMBOL(dma_heap_get_drvdata);
> >>>
> >>> /**
> >>> * dma_heap_get_name - get heap name
> >>> @@ -214,6 +215,7 @@ const char *dma_heap_get_name(struct dma_heap *heap)
> >>> {
> >>> return heap->name;
> >>> }
> >>> +EXPORT_SYMBOL(dma_heap_get_name);
> >>>
> >>> /**
> >>> * dma_heap_add - adds a heap to dmabuf heaps
> >>> @@ -303,6 +305,7 @@ struct dma_heap *dma_heap_add(const struct
> >>> dma_heap_export_info *exp_info)
> >>> kfree(heap);
> >>> return err_ret;
> >>> }
> >>> +EXPORT_SYMBOL(dma_heap_add);
> >>>
> >>> static char *dma_heap_devnode(const struct device *dev, umode_t *mode)
> >>> {
> >>
>
