On Wed, May 28, 2025 at 12:51:19AM +0200, Heiko Stuebner wrote:
> Commit 6579a03e68ff ("drm/bridge: analogix_dp: Remove the unnecessary
> calls to clk_disable_unprepare() during probing") removed the mismatched
> clock_disable calls from analogix_dp_probe.
>
> But that patch was created and sent before
> commit e5e9fa9f7aad ("drm/bridge: analogix_dp: Add support to get panel
> from the DP AUX bus") was merged, so couldn't know about this change.
>
> So in the original patch the last change is
> if (ret) {
> dev_err(&pdev->dev, "failed to request irq\n");
> - goto err_disable_clk;
> + return ERR_PTR(ret);
> }
> disable_irq(dp->irq);
>
> return dp;
> -
> -err_disable_clk:
> - clk_disable_unprepare(dp->clock);
> - return ERR_PTR(ret);
> }
> EXPORT_SYMBOL_GPL(analogix_dp_probe);
>
> the analogix_dp_core.c actually now has the runtime-pm handling between
> disable_irq() and return do introducing another goto err_clk_disable there.
>
> So remove that one too and return an error pointer, to not create build
> breakage.
>
> Fixes: 6579a03e68ff ("drm/bridge: analogix_dp: Remove the unnecessary calls
> to clk_disable_unprepare() during probing")
> Signed-off-by: Heiko Stuebner <he...@sntech.de>
> ---
> When I reviewed the original patch, I failed to see that difference :-(
> But I do wonder how dim was able to apply the original patch.
>
Reviewed-by: Dmitry Baryshkov <dmitry.barysh...@oss.qualcomm.com>
--
With best wishes
Dmitry
