On 5/26/25 16:25, Thomas Zimmermann wrote: > Pin and vmap are two distict operations. Do not mix them. > > The helper drm_client_buffer_vmap() maps the pages for fbdev-dma > and fbdev-shmem. In both cases, the vmap operation ensures that > the pages are available until the vunmap happens. And as the pages > in DMA or SHMEM areas cannot be moved, there is no reason to call > pin. Hence remove the pin call. > > Update drm_client_buffer_vunmap() accordingly. > > v2: > - call 'locked' variants of GEM helpers (Dmitry) > > Signed-off-by: Thomas Zimmermann <tzimmerm...@suse.de> > Reviewed-by: Boris Brezillon <boris.brezil...@collabora.com> > --- > drivers/gpu/drm/drm_client.c | 35 ++++++----------------------------- > 1 file changed, 6 insertions(+), 29 deletions(-)
Reviewed-by: Dmitry Osipenko <dmitry.osipe...@collabora.com> -- Best regards, Dmitry
