On Mon Jun 9, 2025 at 2:22 PM CEST, Guilherme Giacomo Simoes wrote:
> diff --git a/drivers/gpu/nova-core/nova_core.rs
> b/drivers/gpu/nova-core/nova_core.rs
> index 618632f0abcc..f405d7a99c28 100644
> --- a/drivers/gpu/nova-core/nova_core.rs
> +++ b/drivers/gpu/nova-core/nova_core.rs
> @@ -13,7 +13,7 @@
> kernel::module_pci_driver! {
> type: driver::NovaCore,
> name: "NovaCore",
> - author: "Danilo Krummrich",
> + authors: ["Danilo Krummrich"],
Unrelated to this change, I think we should add email addresses to
people in authors. Possibly enforce it by scanning each author element
and checking if there is an email address.
> description: "Nova Core GPU driver",
> license: "GPL v2",
> firmware: [],
> diff --git a/rust/kernel/firmware.rs b/rust/kernel/firmware.rs
> index 2494c96e105f..ed2fc20cba9b 100644
> --- a/rust/kernel/firmware.rs
> +++ b/rust/kernel/firmware.rs
> @@ -181,7 +181,7 @@ unsafe impl Sync for Firmware {}
> /// module! {
> /// type: MyModule,
> /// name: "module_firmware_test",
> -/// author: "Rust for Linux",
> +/// authors: ["Rust for Linux"],
We would need to special case "Rust for Linux Developers" or something
similar. But in several cases -- such as this one, we should just name
the actual authors.
What do you guys think?
---
Cheers,
Benno
