> On Tue, 2025-06-03 at 13:27 +0100, Tvrtko Ursulin wrote: > > On 03/06/2025 10:31, Philipp Stanner wrote: > > What I am not that ecstatic about is only getting the Suggested-by > > credit in 1/6. Given it is basically my patch with some cosmetic > > changes > > like the kernel doc and the cancel loop extracted to a helper. > > Sign the patch off and I give you the authorship if you want.
AFAICS, the proposal of having cancel_job() has been a review comment which has been clarified with a reference patch. IMO, the fact that after some discussion Philipp decided to go with this suggestion and implement the suggestion in his patch series does not result in an obligation for him to hand over authorship of the patch he wrote to the person who suggested the change in the context of the code review. Anyways, it seems that Philipp did offer it however, so this seems to be resolved?
