On Tue, Jun 10, 2025 at 12:40:38PM -0700, Nathan Chancellor wrote:
> This driver requires of_get_display_timing() from
> CONFIG_VIDEOMODE_HELPERS but does not select it. If no other driver
> selects it, there will be a failure from the linker if the driver is
> built in or modpost if it is a module.
>
> ERROR: modpost: "of_get_display_timing"
> [drivers/gpu/drm/sitronix/st7571-i2c.ko] undefined!
>
> Select CONFIG_VIDEOMODE_HELPERS to resolve the build failure.
>
> Fixes: 4b35f0f41ee2 ("drm/st7571-i2c: add support for Sitronix ST7571 LCD
> controller")
> Signed-off-by: Nathan Chancellor <[email protected]>
We've been observing these build failures regularly on certain configs in our
internal -rc1 branch, and this patch fixes it perfectly, thanks for tracking it
down!
Feel free to add:
Tested-by: Pedro Falcato <[email protected]>
and
Acked-by: Pedro Falcato <[email protected]>
--
Pedro
