On Sat, Jun 14, 2025 at 8:09 PM Michal Wilczynski
<m.wilczyn...@samsung.com> wrote:
>
> In order to support the complex power sequencing required by the TH1520
> GPU, the AON power domain driver must be responsible for initiating the
> corresponding sequencer driver. This functionality is specific to
> platforms where the GPU power sequencing hardware is controlled by the
> AON block.
>
> Extend the AON power domain driver to check for the presence of the
> "gpu-clkgen" reset in its own device tree node.
>
> If the property is found, create and register a new auxiliary device.
> This device acts as a proxy that allows the dedicated `pwrseq-thead-gpu`
> auxiliary driver to bind and take control of the sequencing logic.
>
> Signed-off-by: Michal Wilczynski <m.wilczyn...@samsung.com>
> ---
[snip]
> +
> +static int th1520_pd_pwrseq_gpu_init(struct device *dev)
> +{
> + struct auxiliary_device *adev;
> + int ret;
> +
> + /*
> + * Correctly check only for the property's existence in the DT node.
> + * We don't need to get/claim the reset here; that is the job of
> + * the auxiliary driver that we are about to spawn.
> + */
> + if (of_property_match_string(dev->of_node, "reset-names",
> + "gpu-clkgen") < 0)
If you use device_property_match_string() here, you don't need to pull
in of.h. It's typically preferred to use the top-level abstraction
unless not possible.
[snip]
Thanks,
Bartosz
