> -----Original Message-----
> From: Kandpal, Suraj <suraj.kand...@intel.com>
> Sent: Monday, April 14, 2025 9:47 AM
> To: nouv...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; intel-
> x...@lists.freedesktop.org; intel-...@lists.freedesktop.org
> Cc: Nautiyal, Ankit K <ankit.k.nauti...@intel.com>; Murthy, Arun R
> <arun.r.mur...@intel.com>; Kandpal, Suraj <suraj.kand...@intel.com>
> Subject: [PATCH 09/13] drm/dp: Change argument type of
> drm_edp_backlight_enable
>
> Change the argument type to u32 for the default level being sent since it has
> to
> now account for luminance value which has to be set for
> DP_EDP_PANEL_LUMINANCE_TARGET_VALUE.
>
> --v2
> -No need to typecast [Jani]
>
> Signed-off-by: Suraj Kandpal <suraj.kand...@intel.com>
> ---
Reviewed-by: Arun R Murthy <arun.r.mur...@intel.com>
Thanks and Regards,
Arun R Murthy
-------------------
> drivers/gpu/drm/display/drm_dp_helper.c | 2 +-
> drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 +-
> include/drm/display/drm_dp_helper.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/display/drm_dp_helper.c
> b/drivers/gpu/drm/display/drm_dp_helper.c
> index dc0bda84d211..0421b2ed9bd4 100644
> --- a/drivers/gpu/drm/display/drm_dp_helper.c
> +++ b/drivers/gpu/drm/display/drm_dp_helper.c
> @@ -4020,7 +4020,7 @@ drm_edp_backlight_set_enable(struct drm_dp_aux
> *aux, const struct drm_edp_backli
> * Returns: %0 on success, negative error code on failure.
> */
> int drm_edp_backlight_enable(struct drm_dp_aux *aux, const struct
> drm_edp_backlight_info *bl,
> - const u16 level)
> + const u32 level)
> {
> int ret;
> u8 dpcd_buf;
> diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c
> b/drivers/gpu/drm/nouveau/dispnv50/disp.c
> index 725331638a15..e3b8f6f510ef 100644
> --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
> +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
> @@ -1829,7 +1829,7 @@ nv50_sor_atomic_enable(struct drm_encoder
> *encoder, struct drm_atomic_state *sta
> backlight = nv_connector->backlight;
> if (backlight && backlight->uses_dpcd)
> drm_edp_backlight_enable(&nv_connector->aux,
> &backlight->edp_info,
> - (u16)backlight->dev-
> >props.brightness);
> + backlight->dev-
> >props.brightness);
> #endif
>
> break;
> diff --git a/include/drm/display/drm_dp_helper.h
> b/include/drm/display/drm_dp_helper.h
> index 6bce0176efd3..b6c03d3ca6c3 100644
> --- a/include/drm/display/drm_dp_helper.h
> +++ b/include/drm/display/drm_dp_helper.h
> @@ -855,7 +855,7 @@ drm_edp_backlight_init(struct drm_dp_aux *aux,
> struct drm_edp_backlight_info *bl int drm_edp_backlight_set_level(struct
> drm_dp_aux *aux, const struct drm_edp_backlight_info *bl,
> u32 level);
> int drm_edp_backlight_enable(struct drm_dp_aux *aux, const struct
> drm_edp_backlight_info *bl,
> - u16 level);
> + u32 level);
> int drm_edp_backlight_disable(struct drm_dp_aux *aux, const struct
> drm_edp_backlight_info *bl);
>
> #if IS_ENABLED(CONFIG_DRM_KMS_HELPER) &&
> (IS_BUILTIN(CONFIG_BACKLIGHT_CLASS_DEVICE) || \
> --
> 2.34.1
