> -----Original Message----- > From: Kandpal, Suraj <suraj.kand...@intel.com> > Sent: Monday, April 14, 2025 9:47 AM > To: nouv...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; intel- > x...@lists.freedesktop.org; intel-...@lists.freedesktop.org > Cc: Nautiyal, Ankit K <ankit.k.nauti...@intel.com>; Murthy, Arun R > <arun.r.mur...@intel.com>; Kandpal, Suraj <suraj.kand...@intel.com> > Subject: [PATCH 13/13] drm/i915/backlight: Use drm_edp_backlight_enable > > Use drm dp helper to enable backlight now that it has been modified to set > PANEL_LUMINANCE_CONTROL_ENABLE bit based on if capability supports it > and the driver wants it. Remove the dead code. > > Signed-off-by: Suraj Kandpal <suraj.kand...@intel.com> > --- Reviewed-by: Arun R Murthy <arun.r.mur...@intel.com>
Thanks and Regards, Arun R Murthy -------------------- > .../gpu/drm/i915/display/intel_dp_aux_backlight.c | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > index 95b29d9af335..b8b0ace9e6fd 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > @@ -499,20 +499,6 @@ intel_dp_aux_vesa_enable_backlight(const struct > intel_crtc_state *crtc_state, > struct intel_connector *connector = to_intel_connector(conn_state- > >connector); > struct intel_panel *panel = &connector->panel; > struct intel_dp *intel_dp = enc_to_intel_dp(connector->encoder); > - int ret; > - > - if (panel->backlight.edp.vesa.luminance_control_support) { > - ret = drm_dp_dpcd_writeb(&intel_dp->aux, > DP_EDP_BACKLIGHT_MODE_SET_REGISTER, > - > DP_EDP_PANEL_LUMINANCE_CONTROL_ENABLE); > - > - if (ret == 1) > - return; > - > - if (!drm_edp_backlight_set_level(&intel_dp->aux, > - &panel- > >backlight.edp.vesa.info, > - level)) > - return; > - } > > if (!panel->backlight.edp.vesa.info.aux_enable) { > u32 pwm_level; > -- > 2.34.1