On Mon, 2025-06-23 at 18:04 -0400, Mel Henning wrote: > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/priv.h > b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/priv.h > index 4f14e85fc69e..c3494b7ac572 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/priv.h > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/priv.h > @@ -14,7 +14,6 @@ struct nvkm_gsp_fwif { > const struct nvkm_gsp_func *func; > const struct nvkm_rm_impl *rm; > const char *ver; > - bool enable; > };
Instead of removing it, I think we should rename it to indicate whether GSP-RM is required. You cannot boot Ada or later without GSP-RM, so on those platforms, nouveau.config=NvGspRm=0 should be ignored, and a pr_warn should be issued that it is being ignored.