Hi and thanks for your work!

On Fri 27 Dec 24, 16:37, Parthiban Nallathambi wrote:
> lvds, lcd, dsi all shares the same GPIO D bank and lvds0
> data 3 lines and lvds1 pins are missed, add them.

Would it also make sense to submit device-tree pin definitions here?

Thanks!

Paul

> Signed-off-by: Parthiban Nallathambi <[email protected]>
> ---
>  drivers/pinctrl/sunxi/pinctrl-sun50i-a100.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/pinctrl/sunxi/pinctrl-sun50i-a100.c 
> b/drivers/pinctrl/sunxi/pinctrl-sun50i-a100.c
> index df90c75fb3c5..b97de80ae2f3 100644
> --- a/drivers/pinctrl/sunxi/pinctrl-sun50i-a100.c
> +++ b/drivers/pinctrl/sunxi/pinctrl-sun50i-a100.c
> @@ -256,72 +256,84 @@ static const struct sunxi_desc_pin a100_pins[] = {
>                 SUNXI_FUNCTION(0x0, "gpio_in"),
>                 SUNXI_FUNCTION(0x1, "gpio_out"),
>                 SUNXI_FUNCTION(0x2, "lcd0"),          /* D12 */
> +               SUNXI_FUNCTION(0x3, "lvds0"),         /* D3P */
>                 SUNXI_FUNCTION(0x4, "dsi0"),          /* DP3 */
>                 SUNXI_FUNCTION_IRQ_BANK(0x6, 2, 8)),
>       SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 9),
>                 SUNXI_FUNCTION(0x0, "gpio_in"),
>                 SUNXI_FUNCTION(0x1, "gpio_out"),
>                 SUNXI_FUNCTION(0x2, "lcd0"),          /* D13 */
> +               SUNXI_FUNCTION(0x3, "lvds0"),         /* D3N */
>                 SUNXI_FUNCTION(0x4, "dsi0"),          /* DM3 */
>                 SUNXI_FUNCTION_IRQ_BANK(0x6, 2, 9)),
>       SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 10),
>                 SUNXI_FUNCTION(0x0, "gpio_in"),
>                 SUNXI_FUNCTION(0x1, "gpio_out"),
>                 SUNXI_FUNCTION(0x2, "lcd0"),          /* D14 */
> +               SUNXI_FUNCTION(0x3, "lvds1"),         /* D0P */
>                 SUNXI_FUNCTION(0x4, "spi1"),          /* CS */
>                 SUNXI_FUNCTION_IRQ_BANK(0x6, 2, 10)),
>       SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 11),
>                 SUNXI_FUNCTION(0x0, "gpio_in"),
>                 SUNXI_FUNCTION(0x1, "gpio_out"),
>                 SUNXI_FUNCTION(0x2, "lcd0"),          /* D15 */
> +               SUNXI_FUNCTION(0x3, "lvds1"),         /* D0N */
>                 SUNXI_FUNCTION(0x4, "spi1"),          /* CLK */
>                 SUNXI_FUNCTION_IRQ_BANK(0x6, 2, 11)),
>       SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 12),
>                 SUNXI_FUNCTION(0x0, "gpio_in"),
>                 SUNXI_FUNCTION(0x1, "gpio_out"),
>                 SUNXI_FUNCTION(0x2, "lcd0"),          /* D18 */
> +               SUNXI_FUNCTION(0x3, "lvds1"),         /* D1P */
>                 SUNXI_FUNCTION(0x4, "spi1"),          /* MOSI */
>                 SUNXI_FUNCTION_IRQ_BANK(0x6, 2, 12)),
>       SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 13),
>                 SUNXI_FUNCTION(0x0, "gpio_in"),
>                 SUNXI_FUNCTION(0x1, "gpio_out"),
>                 SUNXI_FUNCTION(0x2, "lcd0"),          /* D19 */
> +               SUNXI_FUNCTION(0x3, "lvds1"),         /* D1N */
>                 SUNXI_FUNCTION(0x4, "spi1"),          /* MISO */
>                 SUNXI_FUNCTION_IRQ_BANK(0x6, 2, 13)),
>       SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 14),
>                 SUNXI_FUNCTION(0x0, "gpio_in"),
>                 SUNXI_FUNCTION(0x1, "gpio_out"),
>                 SUNXI_FUNCTION(0x2, "lcd0"),          /* D20 */
> +               SUNXI_FUNCTION(0x3, "lvds1"),         /* D2P */
>                 SUNXI_FUNCTION(0x4, "uart3"),         /* TX */
>                 SUNXI_FUNCTION_IRQ_BANK(0x6, 2, 14)),
>       SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 15),
>                 SUNXI_FUNCTION(0x0, "gpio_in"),
>                 SUNXI_FUNCTION(0x1, "gpio_out"),
>                 SUNXI_FUNCTION(0x2, "lcd0"),          /* D21 */
> +               SUNXI_FUNCTION(0x3, "lvds1"),         /* D2N */
>                 SUNXI_FUNCTION(0x4, "uart3"),         /* RX */
>                 SUNXI_FUNCTION_IRQ_BANK(0x6, 2, 15)),
>       SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 16),
>                 SUNXI_FUNCTION(0x0, "gpio_in"),
>                 SUNXI_FUNCTION(0x1, "gpio_out"),
>                 SUNXI_FUNCTION(0x2, "lcd0"),          /* D22 */
> +               SUNXI_FUNCTION(0x3, "lvds1"),         /* CKP */
>                 SUNXI_FUNCTION(0x4, "uart3"),         /* RTS */
>                 SUNXI_FUNCTION_IRQ_BANK(0x6, 2, 16)),
>       SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 17),
>                 SUNXI_FUNCTION(0x0, "gpio_in"),
>                 SUNXI_FUNCTION(0x1, "gpio_out"),
>                 SUNXI_FUNCTION(0x2, "lcd0"),          /* D23 */
> +               SUNXI_FUNCTION(0x3, "lvds1"),         /* CKN */
>                 SUNXI_FUNCTION(0x4, "uart3"),         /* CTS */
>                 SUNXI_FUNCTION_IRQ_BANK(0x6, 2, 17)),
>       SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 18),
>                 SUNXI_FUNCTION(0x0, "gpio_in"),
>                 SUNXI_FUNCTION(0x1, "gpio_out"),
>                 SUNXI_FUNCTION(0x2, "lcd0"),          /* CLK */
> +               SUNXI_FUNCTION(0x3, "lvds1"),         /* D3P */
>                 SUNXI_FUNCTION(0x4, "uart4"),         /* TX */
>                 SUNXI_FUNCTION_IRQ_BANK(0x6, 2, 18)),
>       SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 19),
>                 SUNXI_FUNCTION(0x0, "gpio_in"),
>                 SUNXI_FUNCTION(0x1, "gpio_out"),
>                 SUNXI_FUNCTION(0x2, "lcd0"),          /* DE */
> +               SUNXI_FUNCTION(0x3, "lvds1"),         /* D3N */
>                 SUNXI_FUNCTION(0x4, "uart4"),         /* RX */
>                 SUNXI_FUNCTION_IRQ_BANK(0x6, 2, 19)),
>       SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 20),
> 
> -- 
> 2.39.5
> 

-- 
Paul Kocialkowski,

Independent contractor - sys-base - https://www.sys-base.io/
Free software developer - https://www.paulk.fr/

Expert in multimedia, graphics and embedded hardware support with Linux.

Attachment: signature.asc
Description: PGP signature

Reply via email to