On Tue Jun 24, 2025 at 5:27 PM CEST, Alice Ryhl wrote: > In the previous patch we added Opaque::cast_from() that performs the > opposite operation to Opaque::raw_get(). For consistency with this > naming, rename raw_get() to cast_from(). > > There are a few other options such as calling cast_from() something > closer to raw_get() rather than renaming this method. However, I could > not find a great naming scheme that works with raw_get(). The previous > version of this patch used from_raw(), but functions of that name > typically have a different signature, so that's not a great option. > > Suggested-by: Danilo Krummrich <[email protected]> > Signed-off-by: Alice Ryhl <[email protected]> > --- > rust/kernel/configfs.rs | 2 +- > rust/kernel/init.rs | 6 +++--- > rust/kernel/lib.rs | 4 ++-- > rust/kernel/list.rs | 2 +- > rust/kernel/list/impl_list_item_mod.rs | 4 ++-- > rust/kernel/time/hrtimer.rs | 4 ++-- > rust/kernel/types.rs | 8 ++++---- > rust/kernel/workqueue.rs | 2 +- > 8 files changed, 16 insertions(+), 16 deletions(-)
For init.rs: Acked-by: Benno Lossin <[email protected]> --- Cheers, Benno
