[Public]
> -----Original Message-----
> From: long.yunj...@zte.com.cn <long.yunj...@zte.com.cn>
> Sent: Friday, June 20, 2025 11:28 PM
> To: Wentland, Harry <harry.wentl...@amd.com>
> Cc: Li, Sun peng (Leo) <sunpeng...@amd.com>; sique...@igalia.com; Deucher,
> Alexander <alexander.deuc...@amd.com>; Koenig, Christian
> <christian.koe...@amd.com>; airl...@gmail.com; sim...@ffwll.ch;
> fang.yum...@zte.com.cn; amd-...@lists.freedesktop.org; dri-
> de...@lists.freedesktop.org; linux-ker...@vger.kernel.org; mou...@zte.com.cn;
> xu.life...@zte.com.cn; ouyang.maoc...@zte.com.cn
> Subject: [PATCH] drm/amd/display: Use str_on_off() helper
>
> From: Yumeng Fang <fang.yum...@zte.com.cn>
>
> Remove hard-coded strings by using the str_on_off() helper.
I personally find that these helpers hurt readability.
Alex
>
> Signed-off-by: Yumeng Fang <fang.yum...@zte.com.cn>
> ---
> drivers/gpu/drm/amd/display/dc/pg/dcn35/dcn35_pg_cntl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/pg/dcn35/dcn35_pg_cntl.c
> b/drivers/gpu/drm/amd/display/dc/pg/dcn35/dcn35_pg_cntl.c
> index af21c0a27f86..509bdb1ca9bc 100644
> --- a/drivers/gpu/drm/amd/display/dc/pg/dcn35/dcn35_pg_cntl.c
> +++ b/drivers/gpu/drm/amd/display/dc/pg/dcn35/dcn35_pg_cntl.c
> @@ -24,6 +24,7 @@
> *
> */
>
> +#include <linux/string_choices.h>
> #include "reg_helper.h"
> #include "core_types.h"
> #include "dcn35_pg_cntl.h"
> @@ -236,7 +237,7 @@ void pg_cntl35_hubp_dpp_pg_control(struct pg_cntl
> *pg_cntl, unsigned int hubp_dp
> }
>
> DC_LOG_DEBUG("HUBP DPP instance %d, power %s", hubp_dpp_inst,
> - power_on ? "ON" : "OFF");
> + str_on_off(power_on));
>
> if (hubp_dpp_inst < MAX_PIPES) {
> pg_cntl->pg_pipe_res_enable[PG_HUBP][hubp_dpp_inst] =
> power_on;
> --
> 2.25.1
