Re: [PATCH v4 02/10] mei: late_bind: add late binding component driver

[Nilawar, Badal]

On 28-06-2025 17:49, Greg KH wrote:

On Wed, Jun 25, 2025 at 10:30:07PM +0530, Badal Nilawar wrote:

+/**
+ * struct late_bind_component_ops - ops for Late Binding services.
+ * @owner: Module providing the ops
+ * @push_config: Sends a config to FW.
+ */
+struct late_bind_component_ops {
+       struct module *owner;

I don't think you ever set this field, so why is it here?

Or did I miss it somewhere?

It is set in drivers/misc/mei/late_bind/mei_late_bind.c

static const struct late_bind_component_ops mei_late_bind_ops = {
        .owner = THIS_MODULE,
        .push_config = mei_late_bind_push_config,
};

Thanks,
Badal

thanks,

greg k-h