Hi Sakari, Thank you for the patch.
On Fri, Jul 04, 2025 at 10:54:13AM +0300, Sakari Ailus wrote: > pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(), > pm_runtime_autosuspend() and pm_request_autosuspend() now include a call > to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to > pm_runtime_mark_last_busy(). > > Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com> > --- > The cover letter of the set can be found here > <URL:https://lore.kernel.org/linux-pm/20250704075225.3212486-1-sakari.ai...@linux.intel.com>. > > In brief, this patch depends on PM runtime patches adding marking the last > busy timestamp in autosuspend related functions. The patches are here, on > rc2: > > git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ > pm-runtime-6.17-rc1 > > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 -- > drivers/gpu/drm/bridge/analogix/anx7625.c | 2 -- > drivers/gpu/drm/bridge/parade-ps8640.c | 2 -- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 1 - > drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 4 ---- > drivers/gpu/drm/exynos/exynos_drm_fimc.c | 2 -- > drivers/gpu/drm/exynos/exynos_drm_g2d.c | 2 -- > drivers/gpu/drm/exynos/exynos_drm_gsc.c | 2 -- > drivers/gpu/drm/exynos/exynos_drm_rotator.c | 1 - > drivers/gpu/drm/exynos/exynos_drm_scaler.c | 1 - > drivers/gpu/drm/i915/intel_runtime_pm.c | 2 -- > drivers/gpu/drm/imx/dcss/dcss-crtc.c | 1 - > drivers/gpu/drm/lima/lima_sched.c | 1 - > drivers/gpu/drm/panel/panel-edp.c | 3 --- > drivers/gpu/drm/panel/panel-samsung-atna33xc20.c | 2 -- > drivers/gpu/drm/panel/panel-simple.c | 2 -- > drivers/gpu/drm/panthor/panthor_sched.c | 2 -- > drivers/gpu/drm/tegra/submit.c | 1 - > drivers/gpu/drm/tidss/tidss_drv.c | 2 -- > drivers/gpu/drm/vc4/vc4_v3d.c | 1 - > 20 files changed, 36 deletions(-) [snip] > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c > b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c > index cf0d9049bcf1..bc5a94dba2d4 100644 > --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c > +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c > @@ -916,13 +916,11 @@ int etnaviv_gpu_init(struct etnaviv_gpu *gpu) > etnaviv_gpu_hw_init(gpu); > mutex_unlock(&gpu->lock); > > - pm_runtime_mark_last_busy(gpu->dev); > pm_runtime_put_autosuspend(gpu->dev); > > return 0; > > fail: You can drop the fail error later and replace it with pm_put. > - pm_runtime_mark_last_busy(gpu->dev); > pm_put: > pm_runtime_put_autosuspend(gpu->dev); > > @@ -1109,7 +1107,6 @@ int etnaviv_gpu_debugfs(struct etnaviv_gpu *gpu, struct > seq_file *m) > > ret = 0; > > - pm_runtime_mark_last_busy(gpu->dev); > pm_put: > pm_runtime_put_autosuspend(gpu->dev); > > @@ -1509,7 +1506,6 @@ void etnaviv_gpu_recover_hang(struct etnaviv_gem_submit > *submit) > etnaviv_gpu_hw_init(gpu); > > mutex_unlock(&gpu->lock); > - pm_runtime_mark_last_busy(gpu->dev); > pm_put: > pm_runtime_put_autosuspend(gpu->dev); > } [snip] > diff --git a/drivers/gpu/drm/vc4/vc4_v3d.c b/drivers/gpu/drm/vc4/vc4_v3d.c > index bb09df5000bd..11ec7e913974 100644 > --- a/drivers/gpu/drm/vc4/vc4_v3d.c > +++ b/drivers/gpu/drm/vc4/vc4_v3d.c > @@ -153,7 +153,6 @@ vc4_v3d_pm_put(struct vc4_dev *vc4) > > mutex_lock(&vc4->power_lock); > if (--vc4->power_refcount == 0) { > - pm_runtime_mark_last_busy(&vc4->v3d->pdev->dev); > pm_runtime_put_autosuspend(&vc4->v3d->pdev->dev); > } And here you can drop the curly braces. With that, Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > mutex_unlock(&vc4->power_lock); -- Regards, Laurent Pinchart
