On Thu, 03 Jul 2025 14:27:43 -0700, Dmitry Baryshkov wrote: > > On Thu, Jul 03, 2025 at 08:49:53PM +0800, Andy Yan wrote:
Hi Andy, > > From: Andy Yan <[email protected]> > > > > In some application scenarios, we hope to get the corresponding > > connector when the bridge's detect hook is invoked. > > > > In most cases, we can get the connector by > > drm_atomic_get_connector_for_encoder > > if the encoder attached to the bridge is enabled, however there will > > still be some scenarios where the detect hook of the bridge is called > > but the corresponding encoder has not been enabled yet. For instance, > > this occurs when the device is hot plug in for the first time. > > > > Since the call to bridge's detect is initiated by the connector, passing > > down the corresponding connector directly will make things simpler. > > > > Signed-off-by: Andy Yan <[email protected]> > > --- > > > > Reviewed-by: Dmitry Baryshkov <[email protected]> This seems to be breaking 'make allmodconfig'. This is what is being seen: ../drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c: In function ‘ge_b850v3_lvds_detect’: ../drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c:145:16: error: too few arguments to function ‘ge_b850v3_lvds_bridge_detect’ 145 | return ge_b850v3_lvds_bridge_detect(&ge_b850v3_lvds_ptr->bridge); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c:124:1: note: declared here 124 | ge_b850v3_lvds_bridge_detect(struct drm_bridge *bridge, struct drm_connector *connector) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c:146:1: error: control reaches end of non-void function [-Werror=return-type] 146 | } | ^ Could you please post a fix for this. Maybe do 'make allmodconfig' to check if you haven't missed anything else. Thanks. -- Ashutosh
