On 15/07/2025 13:24, Chaoyi Chen wrote: > From: Chaoyi Chen <[email protected]> > > Add support for Type-C orientation and altmode switch. > The Type-C controller can be specified to handling switching.
Please describe the hardware in details. Above sentences don't help me to understand this. > > Signed-off-by: Chaoyi Chen <[email protected]> > --- > .../bindings/phy/rockchip,rk3399-typec-phy.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git > a/Documentation/devicetree/bindings/phy/rockchip,rk3399-typec-phy.yaml > b/Documentation/devicetree/bindings/phy/rockchip,rk3399-typec-phy.yaml > index 91c011f68cd0..a885c6893a90 100644 > --- a/Documentation/devicetree/bindings/phy/rockchip,rk3399-typec-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/rockchip,rk3399-typec-phy.yaml > @@ -43,6 +43,20 @@ properties: > description: > Phandle to the syscon managing the "general register files" (GRF). > > + orientation-switch: > + description: Flag the port as possible handler of orientation switching > + type: boolean > + > + mode-switch: > + description: Flag the port as possible handler of altmode switching > + type: boolean > + > + port: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + A port node to link the PHY to a TypeC controller for the purpose of > + handling orientation switching. You are using usb-switch.yaml properties in phy node, which raises questions whether this is actually complete. It might be, but commit msg is so vague that I have doubts. Also, why only one port? Or wait... you already have ports! two of them. This needs to stop, why are you adding more? Best regards, Krzysztof
