On 15/07/2025 13:24, Chaoyi Chen wrote:
> /dts-v1/;
> +#include <dt-bindings/usb/pd.h>
> #include "rk3399.dtsi"
>
> / {
> @@ -19,6 +20,16 @@ chosen {
> stdout-path = "serial2:1500000n8";
> };
>
> + vbus_typec: vbus-typec-regulator {
use consistent naming. How other regulators are called? foo-regulator?
> + compatible = "regulator-fixed";
> + enable-active-high;
> + gpio = <&gpio1 RK_PC2 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&vcc5v0_typec0_en>;
> + regulator-name = "vbus_typec";
> + vin-supply = <&vcc5v0_sys>;
> + };
> +
> vcc5v0_sys: regulator-vcc5v0-sys {
> compatible = "regulator-fixed";
> enable-active-high;
> @@ -29,6 +40,16 @@ vcc5v0_sys: regulator-vcc5v0-sys {
> regulator-max-microvolt = <5000000>;
> regulator-min-microvolt = <5000000>;
> };
> +
> + sound: sound {
> + compatible = "rockchip,rk3399-gru-sound";
> + rockchip,cpu = <&i2s0 &spdif>;
> + };
> +};
> +
> +&cdn_dp {
> + status = "okay";
> + phys = <&tcphy0_dp>;
> };
>
> &cpu_b0 {
> @@ -341,6 +362,66 @@ regulator-state-mem {
> };
> };
>
> +&i2c4 {
> + i2c-scl-rising-time-ns = <475>;
> + i2c-scl-falling-time-ns = <26>;
> + status = "okay";
> +
> + usbc0: fusb302@22 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "fcs,fusb302";
> + reg = <0x22>;
> + interrupt-parent = <&gpio1>;
> + interrupts = <RK_PA2 IRQ_TYPE_LEVEL_LOW>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&usbc0_int>;
> + vbus-supply = <&vbus_typec>;
> + status = "okay";
Why? What disabled it?
> +
> + usb_con: connector {
> + compatible = "usb-c-connector";
> + label = "USB-C";
Best regards,
Krzysztof
