On Sun, Jul 20, 2025 at 02:26:19PM +0200, Krzysztof Kozlowski wrote: > On 19/07/2025 14:09, Otto Pflüger wrote: > > diff --git > > a/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dpu.yaml > > b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dpu.yaml > > index > > 4ebea60b8c5ba5f177854e3a8d89e93e7304e18b..6fedb6e508b247eb71da17ced589b8ed09085592 > > 100644 > > --- a/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dpu.yaml > > +++ b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dpu.yaml > > @@ -16,7 +16,12 @@ description: | > > > > properties: > > compatible: > > - const: sprd,sharkl3-dpu > > + oneOf: > > + - items: > > + - enum: > > + - sprd,ums9230-dpu > > + - const: sprd,sharkl3-dpu > > + - const: sprd,sharkl3-dpu > > > > reg: > > maxItems: 1 > > @@ -25,12 +30,15 @@ properties: > > maxItems: 1 > > > > clocks: > > - minItems: 2 > > + minItems: 1 > > This is wrong. You miss maxItems. I will fix existing bindings.
Will fix this, thanks. > > > > > clock-names: > > - items: > > - - const: clk_src_128m > > - - const: clk_src_384m > > + oneOf: > > + - items: > > + - const: clk_src_128m > > + - const: clk_src_384m > > + - items: > > + - const: enable > > > > power-domains: > > maxItems: 1 > > diff --git > > a/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml > > b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml > > index > > bc5594d18643010b91376c92a8f235a522d7dc3d..8438d2da0a4277db03e30b13cb270684c0c360cb > > 100644 > > --- > > a/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml > > +++ > > b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml > > @@ -11,7 +11,9 @@ maintainers: > > > > properties: > > compatible: > > - const: sprd,sharkl3-dsi-host > > + enum: > > + - sprd,sharkl3-dsi-host > > + - sprd,ums9230-dsi-host > > > > reg: > > maxItems: 1 > > @@ -23,8 +25,11 @@ properties: > > minItems: 1 > > > > clock-names: > > - items: > > - - const: clk_src_96m > > + oneOf: > > + - items: > > + - const: clk_src_96m > > + - items: > > + - const: enable > > Why this is completely different clock? How same class device could have > completely different clock INPUT? The clocks should be the same on sharkl3 (sc9863a) and ums9230, but the existing bindings don't really make sense here or are incomplete. AFAIK there is no SoC in which this display controller is directly connected to the PLL as shown in the example. The DSI controller is connected to a clock gate. The DPU actually does have two clocks, both of which are clock muxes that allow selecting different frequencies and one of which is behind a clock gate. I can add the second clock for the DPU if needed. Since nothing seems to be using these bindings at the moment, would it be okay to drop the old clock names that refer to specific frequencies? > > > > > power-domains: > > maxItems: 1 > > > > > Best regards, > Krzysztof
