On 7/25/25 13:08, Clement LE GOFFIC wrote:
Hi Raphael,

On 7/25/25 12:04, Raphael Gallais-Pou wrote:
The LVDS is used on STM32MP2 as a display interface.

Add the LVDS node.

Signed-off-by: Raphael Gallais-Pou <raphael.gallais-...@foss.st.com>
---
  arch/arm64/boot/dts/st/stm32mp255.dtsi | 12 ++++++++++++
  1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/st/stm32mp255.dtsi b/arch/arm64/boot/ dts/st/stm32mp255.dtsi index f689b47c5010033120146cf1954d6624c0270045..a4d965f785fa42c4597494010855aec7e1b9fdd1 100644
--- a/arch/arm64/boot/dts/st/stm32mp255.dtsi
+++ b/arch/arm64/boot/dts/st/stm32mp255.dtsi
@@ -6,6 +6,18 @@
  #include "stm32mp253.dtsi"
  &rifsc {
+    lvds: lvds@48060000 {
+        compatible = "st,stm32mp25-lvds";

For the compatible you now need one comaptible per SoC.
It means your compatible should look like : "st,stm32mp251-lvds".
This way, if on the 253 or 255 there is an issue you are able to easily add match data in the driver with compatible "st,stm32mp253-lvds" or "st,stm32mp255-lvds". A prior discussion on this subject has been raised on my V1 of HDP involving Krzysztof and Alexandre : https://lore.kernel.org/all/418a80a9-8c08-4dd1- bf49-1bd737832...@kernel.org/
Woops, this comment should target the add of the ltdc compatible as I see that lvds one already exists and can't be changed.
Though the main idea is here.


+        #clock-cells = <0>;
+        reg = <0x48060000 0x2000>;
+        clocks = <&rcc CK_BUS_LVDS>, <&rcc CK_KER_LVDSPHY>;
+        clock-names = "pclk", "ref";
+        resets = <&rcc LVDS_R>;
+        access-controllers = <&rifsc 84>;
+        power-domains = <&CLUSTER_PD>;
+        status = "disabled";
+    };
+
      vdec: vdec@480d0000 {
          compatible = "st,stm32mp25-vdec";
          reg = <0x480d0000 0x3c8>;


Best regards,
Clément

Reply via email to