Hi Dmitry,
On Sun, Jul 27, 2025 at 07:38:12PM +0300, Dmitry Baryshkov wrote:
> On Thu, Jul 24, 2025 at 08:50:52PM +0200, Henrik Grimler wrote:
> > In case of error during resource acquisition the driver should print
> > an error message only if it is not deferred probe. Use dev_err_probe
> > helper to handle this, which will also record defer probe reason for
> > debugging.
[...]
> > @@ -836,9 +835,7 @@ static int sii9234_init_resources(struct sii9234 *ctx,
> > ctx->supplies[3].supply = "cvcc12";
> > ret = devm_regulator_bulk_get(ctx->dev, 4, ctx->supplies);
> > if (ret) {
> > - if (ret != -EPROBE_DEFER)
> > - dev_err(ctx->dev, "regulator_bulk failed\n");
> > - return ret;
> > + dev_err_probe(ctx->dev, ret, "regulator_bulk failed\n");
>
> Drop the braces, use 'return dev_err_probe(...)'
>
> > }
> >
> > ctx->client[I2C_MHL] = client;
Thanks for reviewing and spotting that, will fix in next version!
Best regards,
Henrik Grimler
