Hi, On Tue, Jul 29, 2025 at 11:18 PM Brigham Campbell <m...@brighamcampbell.com> wrote: > > Create mipi_dsi_dcs_read_multi(), which accepts a mipi_dsi_multi_context > struct for improved error handling and cleaner panel driver code. > > Create mipi_dsi_dcs_write_var_seq_multi() and > mipi_dsi_generic_write_var_seq_multi() macros which allow MIPI panel > drivers to write non-static data to display controllers. > > Reviewed-by: Douglas Anderson <diand...@chromium.org> > Signed-off-by: Brigham Campbell <m...@brighamcampbell.com> > --- > > Doug, you had suggested a slightly different shortlog for this patch. I > adjusted your suggestion to fit within the canonical recommended > shortlog length of 50 characters. I understand that the 50 character > limit isn't a rule as much as it is a guideline, but the current > shortlog seems to me like a good compromise.
Looks good. > @@ -431,6 +449,23 @@ void mipi_dsi_dcs_set_tear_off_multi(struct > mipi_dsi_multi_context *ctx); > mipi_dsi_dcs_write_buffer_multi(ctx, d, ARRAY_SIZE(d)); \ > } while (0) > > +/** > + * mipi_dsi_dcs_write_var_seq_multi - transmit a DCS command with non-static > + * payload I should have been explicit, but the above "non-static" should also be "non-constant". ;-) I could probably fix that when applying, or you could send a v4. Up to you. Speaking of applying this, I'll be on vacation next week, so I won't be able to apply the patches until the week after. That will also give anyone else on the list a chance to comment if they want... -Doug
