On Fri, 2025-08-01 at 16:39 +0200, Thomas Hellström wrote: > On Fri, 2025-08-01 at 19:19 +0900, Simon Richter wrote: > > This driver, for the time being, assumes that the kernel page size > > is > > 4kB, > > so it fails on loong64 and aarch64 with 16kB pages, and ppc64el > > with > > 64kB > > pages. > > > > Signed-off-by: Simon Richter <simon.rich...@hogyros.de> > > Cc: sta...@vger.kernel.org > > Reviewed-by: Thomas Hellström <thomas.hellst...@linux.intel.com> > I will add a Fixes: tag and push this. > > Thanks, > Thomas
Actually, I see that the patch in its current form will cause grief when backporting since that depends line has changed during driver lifetime. I noticed that when trying to find a good Fixes: tag. Would you mind if we did the following: > > > > --- > > drivers/gpu/drm/xe/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/xe/Kconfig > > b/drivers/gpu/drm/xe/Kconfig > > index 2bb2bc052120..ea12ff033439 100644 > > --- a/drivers/gpu/drm/xe/Kconfig > > +++ b/drivers/gpu/drm/xe/Kconfig > > @@ -1,7 +1,7 @@ > > # SPDX-License-Identifier: GPL-2.0-only > > config DRM_XE > > tristate "Intel Xe2 Graphics" > > - depends on DRM && PCI > > + depends on DRM && PCI && (PAGE_SIZE_4KB || COMPILE_TEST || > > BROKEN) Scratch this change > > depends on KUNIT || !KUNIT > > depends on INTEL_VSEC || !INTEL_VSEC > > depends on X86_PLATFORM_DEVICES || !(X86 && ACPI) And instead here add depends on PAGE_SIZE_4KB || COMPILE_TEST || BROKEN Thanks, Thomas > >