On Sat, Aug 2, 2025 at 4:28 AM Ethan Carter Edwards
<et...@ethancedwards.com> wrote:
>
> The repeated checks on grbm_soft_reset are unnecessary. Remove them.
>
Same comment as the gfx10 patch. These are necessary.
Alex
> Signed-off-by: Ethan Carter Edwards <et...@ethancedwards.com>
> ---
> drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 24 +++++++++++-------------
> 1 file changed, 11 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
> b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
> index
> 51babf5c78c86c20ef806e31e9d0a4185ffda5b8..8ba66d4dfe86e96073f63e259177ca0ca2416a6d
> 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
> @@ -2461,19 +2461,17 @@ static int gfx_v9_4_3_soft_reset(struct
> amdgpu_ip_block *ip_block)
> /* Disable MEC parsing/prefetching */
> gfx_v9_4_3_xcc_cp_compute_enable(adev, false, 0);
>
> - if (grbm_soft_reset) {
> - tmp = RREG32_SOC15(GC, GET_INST(GC, 0),
> regGRBM_SOFT_RESET);
> - tmp |= grbm_soft_reset;
> - dev_info(adev->dev, "GRBM_SOFT_RESET=0x%08X\n", tmp);
> - WREG32_SOC15(GC, GET_INST(GC, 0), regGRBM_SOFT_RESET,
> tmp);
> - tmp = RREG32_SOC15(GC, GET_INST(GC, 0),
> regGRBM_SOFT_RESET);
> -
> - udelay(50);
> -
> - tmp &= ~grbm_soft_reset;
> - WREG32_SOC15(GC, GET_INST(GC, 0), regGRBM_SOFT_RESET,
> tmp);
> - tmp = RREG32_SOC15(GC, GET_INST(GC, 0),
> regGRBM_SOFT_RESET);
> - }
> + tmp = RREG32_SOC15(GC, GET_INST(GC, 0), regGRBM_SOFT_RESET);
> + tmp |= grbm_soft_reset;
> + dev_info(adev->dev, "GRBM_SOFT_RESET=0x%08X\n", tmp);
> + WREG32_SOC15(GC, GET_INST(GC, 0), regGRBM_SOFT_RESET, tmp);
> + tmp = RREG32_SOC15(GC, GET_INST(GC, 0), regGRBM_SOFT_RESET);
> +
> + udelay(50);
> +
> + tmp &= ~grbm_soft_reset;
> + WREG32_SOC15(GC, GET_INST(GC, 0), regGRBM_SOFT_RESET, tmp);
> + tmp = RREG32_SOC15(GC, GET_INST(GC, 0), regGRBM_SOFT_RESET);
>
> /* Wait a little for things to settle down */
> udelay(50);
>
> ---
> base-commit: b9ddaa95fd283bce7041550ddbbe7e764c477110
> change-id: 20250801-uartlite-redundant-c4cb6f87bb68
>
> Best regards,
> --
> Ethan Carter Edwards <et...@ethancedwards.com>
>
