On Tue, Aug 12, 2025 at 04:51:34PM +0200, Mike Looijmans wrote: > Add DT binding document for TI TMDS181 and SN65DP159 HDMI retimers. > > Signed-off-by: Mike Looijmans <mike.looijm...@topic.nl> > --- > > .../bindings/display/bridge/ti,tmds181.yaml | 104 ++++++++++++++++++ > 1 file changed, 104 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/bridge/ti,tmds181.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,tmds181.yaml > b/Documentation/devicetree/bindings/display/bridge/ti,tmds181.yaml > new file mode 100644 > index 000000000000..87ffb556c4ad > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/ti,tmds181.yaml > @@ -0,0 +1,104 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/ti,tmds181.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: TMDS181 and SN65DP159 HDMI retimer/redriver chips > + > +maintainers: > + - Mike Looijmans <mike.looijm...@topic.nl> > + > +description: | > + Texas Instruments TMDS181 and SN65DP159 retimer and redriver chips. > + https://www.ti.com/product/TMDS181 > + https://www.ti.com/product/TMDS181
These two links are the same.
> +
> +properties:
> + compatible:
> + enum:
> + - ti,tmds181
> + - ti,sn65dp159
The driver contains:
+ { .compatible = "ti,tmds181", },
+ { .compatible = "ti,sn65dp159", },
+ {}
so why is a fallback compatible not suitable here?
Otherwise, this looks fine to me.
> +
> + reg:
> + enum:
> + - 0x5b
> + - 0x5c
> + - 0x5d
> + - 0x5e
> +
> + oe-gpios:
> + maxItems: 1
> + description: GPIO specifier for OE pin (active high).
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + properties:
> + port@0:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + unevaluatedProperties: false
> + description: Video port for HDMI (ish) input
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + unevaluatedProperties: false
> +
> + port@1:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + unevaluatedProperties: false
> + description: Video port for HDMI output (panel or bridge)
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + unevaluatedProperties: false
> +
> + required:
> + - port@0
> + - port@1
> +
> +required:
> + - compatible
> + - reg
> + - ports
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + bridge@5b {
> + compatible = "ti,sn65dp159";
> + reg = <0x5b>;
> +
> + oe-gpios = <&gpio2 1 GPIO_ACTIVE_HIGH>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> +
> + endpoint {
> + remote-endpoint = <&encoder_out>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> +
> + endpoint {
> + remote-endpoint = <&hdmi_connector_in>;
> + };
> + };
> + };
> + };
> + };
> --
> 2.43.0
>
>
> Met vriendelijke groet / kind regards,
>
> Mike Looijmans
> System Expert
>
>
> TOPIC Embedded Products B.V.
> Materiaalweg 4, 5681 RJ Best
> The Netherlands
>
> T: +31 (0) 499 33 69 69
> E: mike.looijm...@topic.nl
> W: www.topic.nl
>
> Please consider the environment before printing this e-mail
signature.asc
Description: PGP signature
