Re: [PATCH] drm/amd/display: Use swap() to simplify code

[Alex Hung]

Reviewed-by: Alex Hung <alex.h...@amd.com>

On 8/6/25 06:41, Liao Yuanhong wrote:

Replace the original swapping logic with swap() to improve readability and
remove temporary variables

Signed-off-by: Liao Yuanhong <liaoyuanh...@vivo.com>
---
  drivers/gpu/drm/amd/display/dc/dml2/dml2_dc_resource_mgmt.c | 6 ++----
  1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml2_dc_resource_mgmt.c 
b/drivers/gpu/drm/amd/display/dc/dml2/dml2_dc_resource_mgmt.c
index 5f1b49a50049..4cfe64aa8492 100644
--- a/drivers/gpu/drm/amd/display/dc/dml2/dml2_dc_resource_mgmt.c
+++ b/drivers/gpu/drm/amd/display/dc/dml2/dml2_dc_resource_mgmt.c
@@ -473,7 +473,6 @@ static void sort_pipes_for_splitting(struct 
dc_plane_pipe_pool *pipes)
  {
        bool sorted, swapped;
        unsigned int cur_index;
-       unsigned int temp;
        int odm_slice_index;

for (odm_slice_index = 0; odm_slice_index < pipes->num_pipes_assigned_to_plane_for_odm_combine; odm_slice_index++) {

@@ -489,9 +488,8 @@ static void sort_pipes_for_splitting(struct 
dc_plane_pipe_pool *pipes)
                swapped = false;
                while (!sorted) {
                        if 
(pipes->pipes_assigned_to_plane[odm_slice_index][cur_index] > 
pipes->pipes_assigned_to_plane[odm_slice_index][cur_index + 1]) {
-                               temp = 
pipes->pipes_assigned_to_plane[odm_slice_index][cur_index];
-                               
pipes->pipes_assigned_to_plane[odm_slice_index][cur_index] = 
pipes->pipes_assigned_to_plane[odm_slice_index][cur_index + 1];
-                               
pipes->pipes_assigned_to_plane[odm_slice_index][cur_index + 1] = temp;
+                               
swap(pipes->pipes_assigned_to_plane[odm_slice_index][cur_index + 1],
+                                        
pipes->pipes_assigned_to_plane[odm_slice_index][cur_index]);

swapped = true;

                        }