On Mon, Aug 25, 2025 at 10:15:50PM +0800, Yongxing Mou wrote: > From: Abhinav Kumar <quic_abhin...@quicinc.com> > > dp_display_disable() handles special case of when monitor is > disconnected from the dongle while the dongle stays connected > thereby needing a separate function dp_ctrl_off_link_stream() > for this. However with a slight rework this can still be handled > by keeping common paths same for regular and special case.
I'm mostly sure that this needs to be reworked by the HPD patchset (or as a part of this patchset). The DP controller and the AUX channel needs to be on for as long as there is a DPRX connected to the DP port. The atomic_enable() / atomic_disable() callbacks should only be handling the data lanes. Nevertheless the patch on its own is correct. Reviewed-by: Dmitry Baryshkov <dmitry.barysh...@oss.qualcomm.com> > > Signed-off-by: Abhinav Kumar <quic_abhin...@quicinc.com> > Signed-off-by: Yongxing Mou <yongxing....@oss.qualcomm.com> > --- > drivers/gpu/drm/msm/dp/dp_ctrl.c | 19 +------------------ > drivers/gpu/drm/msm/dp/dp_ctrl.h | 3 ++- > drivers/gpu/drm/msm/dp/dp_display.c | 10 +++++++++- > 3 files changed, 12 insertions(+), 20 deletions(-) > -- With best wishes Dmitry
