[PATCH v3 6/6] drm: Convert tile_idr to XArray

[Sidhartha Kumar]

From: Matthew Wilcox <wi...@infradead.org>

From: Matthew Wilcox <wi...@infradead.org>

Convert tile_idr to an Xarray. tg->id and tg are not modified so the
indentifiers are unchanged.

Signed-off-by: Matthew Wilcox <wi...@infradead.org>
Signed-off-by: Sidhartha Kumar <sidhartha.ku...@oracle.com>
---
 drivers/gpu/drm/drm_connector.c   | 26 ++++++++++----------------
 drivers/gpu/drm/drm_mode_config.c |  3 +--
 include/drm/drm_mode_config.h     | 12 ++++++------
 3 files changed, 17 insertions(+), 24 deletions(-)

diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
index 272d6254ea47..6a64e20d730a 100644
--- a/drivers/gpu/drm/drm_connector.c
+++ b/drivers/gpu/drm/drm_connector.c
@@ -3531,9 +3531,7 @@ static void drm_tile_group_free(struct kref *kref)
        struct drm_tile_group *tg = container_of(kref, struct drm_tile_group, 
refcount);
        struct drm_device *dev = tg->dev;
 
-       mutex_lock(&dev->mode_config.idr_mutex);
-       idr_remove(&dev->mode_config.tile_idr, tg->id);
-       mutex_unlock(&dev->mode_config.idr_mutex);
+       xa_erase(&dev->mode_config.tiles, tg->id);
        kfree(tg);
 }
 
@@ -3565,19 +3563,18 @@ struct drm_tile_group *drm_mode_get_tile_group(struct 
drm_device *dev,
                                               const char topology[8])
 {
        struct drm_tile_group *tg;
-       int id;
+       unsigned long id;
 
-       mutex_lock(&dev->mode_config.idr_mutex);
-       idr_for_each_entry(&dev->mode_config.tile_idr, tg, id) {
+       xa_lock(&dev->mode_config.tiles);
+       xa_for_each(&dev->mode_config.tiles, id, tg) {
                if (!memcmp(tg->group_data, topology, 8)) {
                        if (!kref_get_unless_zero(&tg->refcount))
                                tg = NULL;
-                       mutex_unlock(&dev->mode_config.idr_mutex);
-                       return tg;
+                       break;
                }
        }
-       mutex_unlock(&dev->mode_config.idr_mutex);
-       return NULL;
+       xa_unlock(&dev->mode_config.tiles);
+       return tg;
 }
 EXPORT_SYMBOL(drm_mode_get_tile_group);
 
@@ -3606,16 +3603,13 @@ struct drm_tile_group 
*drm_mode_create_tile_group(struct drm_device *dev,
        memcpy(tg->group_data, topology, 8);
        tg->dev = dev;
 
-       mutex_lock(&dev->mode_config.idr_mutex);
-       ret = idr_alloc(&dev->mode_config.tile_idr, tg, 1, 0, GFP_KERNEL);
-       if (ret >= 0) {
-               tg->id = ret;
-       } else {
+       ret = xa_alloc(&dev->mode_config.tiles, &tg->id, tg, xa_limit_32b,
+                       GFP_KERNEL);
+       if (ret < 0) {
                kfree(tg);
                tg = NULL;
        }
 
-       mutex_unlock(&dev->mode_config.idr_mutex);
        return tg;
 }
 EXPORT_SYMBOL(drm_mode_create_tile_group);
diff --git a/drivers/gpu/drm/drm_mode_config.c 
b/drivers/gpu/drm/drm_mode_config.c
index 25f376869b3a..680b97ab58ec 100644
--- a/drivers/gpu/drm/drm_mode_config.c
+++ b/drivers/gpu/drm/drm_mode_config.c
@@ -439,7 +439,7 @@ int drmm_mode_config_init(struct drm_device *dev)
        INIT_LIST_HEAD(&dev->mode_config.plane_list);
        INIT_LIST_HEAD(&dev->mode_config.privobj_list);
        idr_init_base(&dev->mode_config.object_idr, 1);
-       idr_init_base(&dev->mode_config.tile_idr, 1);
+       xa_init_flags(&dev->mode_config.tiles, XA_FLAGS_ALLOC1);
        ida_init(&dev->mode_config.connector_ida);
        spin_lock_init(&dev->mode_config.connector_list_lock);
 
@@ -578,7 +578,6 @@ void drm_mode_config_cleanup(struct drm_device *dev)
        }
 
        ida_destroy(&dev->mode_config.connector_ida);
-       idr_destroy(&dev->mode_config.tile_idr);
        idr_destroy(&dev->mode_config.object_idr);
        drm_modeset_lock_fini(&dev->mode_config.connection_mutex);
 }
diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h
index 2e848b816218..9e3914119587 100644
--- a/include/drm/drm_mode_config.h
+++ b/include/drm/drm_mode_config.h
@@ -393,8 +393,8 @@ struct drm_mode_config {
        /**
         * @idr_mutex:
         *
-        * Mutex for KMS ID allocation and management. Protects both @object_idr
-        * and @tile_idr.
+        * Mutex for KMS ID allocation and management. Protects the
+        * objects in @object_idr.
         */
        struct mutex idr_mutex;
 
@@ -407,12 +407,12 @@ struct drm_mode_config {
        struct idr object_idr;
 
        /**
-        * @tile_idr:
+        * @tiles:
         *
-        * Use this idr for allocating new IDs for tiled sinks like use in some
-        * high-res DP MST screens.
+        * Use this for allocating new IDs for tiled sinks like those
+        * used in some high-res DP MST screens.
         */
-       struct idr tile_idr;
+       struct xarray tiles;
 
        /** @fb_lock: Mutex to protect fb the global @fb_list and @num_fb. */
        struct mutex fb_lock;
-- 
2.43.0