Am Montag, 25. August 2025, 10:28:39 Mitteleuropäische Sommerzeit schrieb Nicolas Frattaroli: > The sp7021 clock driver has its own shifted high word mask macro, > similar to the ones many Rockchip drivers have. > > Remove it, and replace instances of it with hw_bitfield.h's > FIELD_PREP_WM16 macro, which does the same thing except in a common > macro that also does compile-time error checking. > > This was compile-tested with 32-bit ARM with Clang, no runtime tests > were performed as I lack the hardware. However, I verified that fix > commit 5c667d5a5a3e ("clk: sp7021: Adjust width of _m in HWM_FIELD_PREP()") > is not regressed. No warning is produced. > > Signed-off-by: Nicolas Frattaroli <nicolas.frattar...@collabora.com>
While I have no connection with that specific piece of hardware, the change itself looks correct, so Reviewed-by: Heiko Stuebner <he...@sntech.de>