On Mon, Aug 25, 2025 at 03:43:08PM +0200, Maxime Ripard wrote: > The drm_atomic_get_connector_state() function calls the deprecated > drm_atomic_get_existing_connector_state() helper to get find if a > connector state had already been allocated and was part of the given > drm_atomic_state. > > At the point in time where drm_atomic_get_connector_state() can be > called (ie, during atomic_check), the existing state is the new state > and drm_atomic_get_existing_connector_state() can thus be replaced by > drm_atomic_get_new_connector_state(). > > Signed-off-by: Maxime Ripard <mrip...@kernel.org> > --- > drivers/gpu/drm/drm_atomic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c > index > 660b081ff5d8c39061cebfb5ea122ac1e51677ad..30b7ec05a1af07075e40cd2822ecfd67df004ba2 > 100644 > --- a/drivers/gpu/drm/drm_atomic.c > +++ b/drivers/gpu/drm/drm_atomic.c > @@ -1128,11 +1128,11 @@ drm_atomic_get_connector_state(struct > drm_atomic_state *state, > struct drm_mode_config *config = &connector->dev->mode_config; > struct drm_connector_state *connector_state; > > WARN_ON(!state->acquire_ctx); > > - connector_state = drm_atomic_get_existing_connector_state(state, > connector); > + connector_state = drm_atomic_get_new_connector_state(state, connector);
I'd say, drop patches 1-2 and use this function directly as is now. > if (connector_state) > return connector_state; > > ret = drm_modeset_lock(&config->connection_mutex, state->acquire_ctx); > if (ret) > > -- > 2.50.1 > -- With best wishes Dmitry
