On 22.08.2025 10:29, Faith Ekstrand wrote:
> Signed-off-by: Faith Ekstrand <faith.ekstr...@collabora.com>
> ---
> drivers/gpu/drm/panfrost/panfrost_drv.c | 7 +++++--
> drivers/gpu/drm/panfrost/panfrost_gem.c | 3 +++
> include/uapi/drm/panfrost_drm.h | 1 +
> 3 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c
> b/drivers/gpu/drm/panfrost/panfrost_drv.c
> index 1ea6c509a5d5..ac2a3939f0c1 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_drv.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
> @@ -116,6 +116,10 @@ static int panfrost_ioctl_get_param(struct drm_device
> *ddev, void *data, struct
> return 0;
> }
>
> +#define PANFROST_BO_FLAGS (PANFROST_BO_NOEXEC | \
> + PANFROST_BO_HEAP | \
> + PANFROST_BO_WB_MMAP)
> +
> static int panfrost_ioctl_create_bo(struct drm_device *dev, void *data,
> struct drm_file *file)
> {
> @@ -125,8 +129,7 @@ static int panfrost_ioctl_create_bo(struct drm_device
> *dev, void *data,
> struct panfrost_gem_mapping *mapping;
> int ret;
>
> - if (!args->size || args->pad ||
> - (args->flags & ~(PANFROST_BO_NOEXEC | PANFROST_BO_HEAP)))
> + if (!args->size || args->pad || (args->flags & ~PANFROST_BO_FLAGS))
> return -EINVAL;
>
> /* Heaps should never be executable */
> diff --git a/drivers/gpu/drm/panfrost/panfrost_gem.c
> b/drivers/gpu/drm/panfrost/panfrost_gem.c
> index bb73f2a68a12..9a707055d946 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_gem.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_gem.c
> @@ -320,6 +320,9 @@ panfrost_gem_create(struct drm_device *dev, size_t size,
> u32 flags)
> bo->noexec = !!(flags & PANFROST_BO_NOEXEC);
> bo->is_heap = !!(flags & PANFROST_BO_HEAP);
>
> + if (flags & PANFROST_BO_WB_MMAP)
> + bo->base.map_wc = true;
> +
How come in the case of Panthor,
if (flags & DRM_PANTHOR_BO_WB_MMAP)
shmem->map_wc = false;
but here, it means we would map the BO WC instead?
> return bo;
> }
>
> diff --git a/include/uapi/drm/panfrost_drm.h b/include/uapi/drm/panfrost_drm.h
> index ed67510395bd..e09b6f25acb2 100644
> --- a/include/uapi/drm/panfrost_drm.h
> +++ b/include/uapi/drm/panfrost_drm.h
> @@ -90,6 +90,7 @@ struct drm_panfrost_wait_bo {
> /* Valid flags to pass to drm_panfrost_create_bo */
> #define PANFROST_BO_NOEXEC 1
> #define PANFROST_BO_HEAP 2
> +#define PANFROST_BO_WB_MMAP 4
>
> /**
> * struct drm_panfrost_create_bo - ioctl argument for creating Panfrost BOs.
> --
> 2.50.1
Adrian Larumbe
