Liao Yuanhong <liaoyuanh...@vivo.com> writes: Hello Liao,
Thanks for your patch. > Logging messages that show some type of "out of memory" error are generally > unnecessary as there is a generic message and a stack dump done by the > memory subsystem. These messages generally increase kernel size without > much added value[1]. > > The dev_err_probe() doesn't do anything when error is '-ENOMEM'. Therefore, > remove the useless call to dev_err_probe(), and just return the value > instead. > > [1]: https://lore.kernel.org/lkml/1402419340.30479.18.camel@joe-AO725/ > > Signed-off-by: Liao Yuanhong <liaoyuanh...@vivo.com> > --- > drivers/gpu/drm/solomon/ssd130x-spi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/solomon/ssd130x-spi.c > b/drivers/gpu/drm/solomon/ssd130x-spi.c > index 7c935870f7d2..b52f5fd592a1 100644 > --- a/drivers/gpu/drm/solomon/ssd130x-spi.c > +++ b/drivers/gpu/drm/solomon/ssd130x-spi.c > @@ -74,8 +74,7 @@ static int ssd130x_spi_probe(struct spi_device *spi) > > t = devm_kzalloc(dev, sizeof(*t), GFP_KERNEL); > if (!t) > - return dev_err_probe(dev, -ENOMEM, > - "Failed to allocate SPI transport data\n"); > + return -ENOMEM; > > t->spi = spi; > t->dc = dc; > -- > 2.34.1 > Reviewed-by: Javier Martinez Canillas <javi...@redhat.com> Pushed to drm-misc (drm-misc-next). Thanks! -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
