On Mon, Aug 18, 2025 at 8:56 PM Heiko Stuebner <he...@sntech.de> wrote:
>
> Right now, the code checks the DMA_READ_ERROR state 2 times, while
> I guess it was supposed to warn about both read and write errors.
>
> Change the 2nd check to look at the write-error flag.
>
> Fixes: 0810d5ad88a1 ("accel/rocket: Add job submission IOCTL")
> Signed-off-by: Heiko Stuebner <he...@sntech.de>Thanks, Heiko, you are right, I have applied it to drm-misc-next. Regards, Tomeu > --- > drivers/accel/rocket/rocket_job.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/accel/rocket/rocket_job.c > b/drivers/accel/rocket/rocket_job.c > index 5d4afd692306..3440b862e749 100644 > --- a/drivers/accel/rocket/rocket_job.c > +++ b/drivers/accel/rocket/rocket_job.c > @@ -422,7 +422,7 @@ static irqreturn_t rocket_job_irq_handler(int irq, void > *data) > u32 raw_status = rocket_pc_readl(core, INTERRUPT_RAW_STATUS); > > WARN_ON(raw_status & PC_INTERRUPT_RAW_STATUS_DMA_READ_ERROR); > - WARN_ON(raw_status & PC_INTERRUPT_RAW_STATUS_DMA_READ_ERROR); > + WARN_ON(raw_status & PC_INTERRUPT_RAW_STATUS_DMA_WRITE_ERROR); > > if (!(raw_status & PC_INTERRUPT_RAW_STATUS_DPU_0 || > raw_status & PC_INTERRUPT_RAW_STATUS_DPU_1)) > -- > 2.47.2 >
