On Tue, Sep 02, 2025 at 03:42:55PM +0800, Yongxing Mou wrote: > > > On 9/2/2025 2:41 PM, Krzysztof Kozlowski wrote: > > On 02/09/2025 08:38, Krzysztof Kozlowski wrote: > > > On Mon, Sep 01, 2025 at 05:57:30PM +0800, Yongxing Mou wrote: > > > > + - if: > > > > + properties: > > > > + compatible: > > > > + contains: > > > > + enum: > > > > + # QCS8300 only has one DP controller that supports 4 > > > > + # streams MST. > > > > + - qcom,qcs8300-dp > > > > + then: > > > > + properties: > > > > + reg: > > > > + minItems: 9 > > > > + maxItems: 9 > > > > + clocks: > > > > + minItems: 8 > > > > + maxItems: 8 > > > > > > Clocks have only five items, reg has 5. At least in my next from few > > > days ago. > > > > > > Nothing explains any patchset dependencies, so this makes reviewing more > > > difficult than it should be. > > OK, I found the dependency in cover letter (I was looking at wrong cover > > letter), but the dependency does not have relevant clock changes, so > > this is still wrong. > > > Hi, > https://lore.kernel.org/all/[email protected]/ > dp-controller.yaml descriptions for regs and clks have been added. Compare > with SA8775P, QCS8300 don't have DP1 controller which supports 2 streams > MST, so its minItems and maxItems clocks is 8. > I suggest to slow down with > this patchset. It's v10 already with > > simultaneous other changes and two (!!!) dependencies. > > Sorry for that, will wait until the dependencies become stable before > updating the patch.> I don't know how I am supposed to review this.
Please fix you email client. This is garbled. It mixes your text and Krzysztof's on the same line. > > > > Best regards, > > Krzysztof > -- With best wishes Dmitry
