From: Mukesh Rathor <mrat...@linux.microsoft.com> Sent: Wednesday, August 27,
2025 6:00 PM
Same comment about patch "Subject:" prefix.
> CONFIG_HYPERV is an umbrella config option involved in enabling hyperv
s/hyperv/Hyper-V/
> support and build of modules like hyperv-balloon, hyperv-vmbus, etc..
With CONFIG_HYPERV and CONFIG_HYPERV_VMBUS separated, I think
of CONFIG_HYPERV as the core Hyper-V hypervisor support, such as
hypercalls, clocks/timers, Confidential Computing setup, etc. that
doesn't involve VMBus or VMBus devices.
> As such it should be bool and the hack in Makefile be removed.
>
> Signed-off-by: Mukesh Rathor <mrat...@linux.microsoft.com>
> ---
> drivers/Makefile | 2 +-
> drivers/hv/Kconfig | 2 +-
> drivers/hv/Makefile | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/Makefile b/drivers/Makefile
> index b5749cf67044..7ad5744db0b6 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -161,7 +161,7 @@ obj-$(CONFIG_SOUNDWIRE) += soundwire/
>
> # Virtualization drivers
> obj-$(CONFIG_VIRT_DRIVERS) += virt/
> -obj-$(subst m,y,$(CONFIG_HYPERV)) += hv/
> +obj-$(CONFIG_HYPERV) += hv/
>
> obj-$(CONFIG_PM_DEVFREQ) += devfreq/
> obj-$(CONFIG_EXTCON) += extcon/
> diff --git a/drivers/hv/Kconfig b/drivers/hv/Kconfig
> index 08c4ed005137..b860bc1026b7 100644
> --- a/drivers/hv/Kconfig
> +++ b/drivers/hv/Kconfig
> @@ -3,7 +3,7 @@
> menu "Microsoft Hyper-V guest support"
>
> config HYPERV
> - tristate "Microsoft Hyper-V client drivers"
> + bool "Microsoft Hyper-V client drivers"
I would want to change the prompt here to be more specific, such as:
bool "Microsoft Hyper-V core hypervisor support"
As noted in my comments on the cover letter, this change causes
.config file compatibility problems. I can't immediately think of
a way to deal with the compatibility problem and still change this
from tristate to bool.
> depends on (X86 && X86_LOCAL_APIC && HYPERVISOR_GUEST) \
> || (ARM64 && !CPU_BIG_ENDIAN)
> select PARAVIRT
> diff --git a/drivers/hv/Makefile b/drivers/hv/Makefile
> index 050517756a82..8b04a33e4dd8 100644
> --- a/drivers/hv/Makefile
> +++ b/drivers/hv/Makefile
> @@ -18,7 +18,7 @@ mshv_root-y := mshv_root_main.o mshv_synic.o
> mshv_eventfd.o mshv_irq.o \
> mshv_vtl-y := mshv_vtl_main.o
>
> # Code that must be built-in
> -obj-$(subst m,y,$(CONFIG_HYPERV)) += hv_common.o
> +obj-$(CONFIG_HYPERV) += hv_common.o
> obj-$(subst m,y,$(CONFIG_MSHV_ROOT)) += hv_proc.o
> ifneq ($(CONFIG_MSHV_ROOT) $(CONFIG_MSHV_VTL),)
> obj-y += mshv_common.o
> --
> 2.36.1.vfs.0.0
>
