Hi Maxime, Le mardi 02 septembre 2025 à 11:35 +0200, Maxime Ripard a écrit : > The ingenic atomic_check implementation uses the deprecated > drm_atomic_get_existing_crtc_state() helper. > > This hook is called as part of the global atomic_check, thus before > the > states are swapped. The existing state thus points to the new state, > and > we can use drm_atomic_get_new_crtc_state() instead. > > Signed-off-by: Maxime Ripard <mrip...@kernel.org>
Reviewed-by: Paul Cercueil <p...@crapouillou.net> and/or: Tested-by: Paul Cercueil <p...@crapouillou.net> Cheers, -Paul > > --- > To: Paul Cercueil <p...@crapouillou.net> > Cc: linux-m...@vger.kernel.org > --- > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 3 +-- > drivers/gpu/drm/ingenic/ingenic-ipu.c | 2 +- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > index > 9db1ceaed5188a4ef0897280dc72108eb3815b5f..05faed933e5619c796f2a4fa190 > 6e0eaa029ac68 100644 > --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > @@ -469,12 +469,11 @@ static int > ingenic_drm_plane_atomic_check(struct drm_plane *plane, > return 0; > > if (priv->soc_info->plane_f0_not_working && plane == &priv- > >f0) > return -EINVAL; > > - crtc_state = drm_atomic_get_existing_crtc_state(state, > - crtc); > + crtc_state = drm_atomic_get_new_crtc_state(state, crtc); > if (WARN_ON(!crtc_state)) > return -EINVAL; > > priv_state = ingenic_drm_get_priv_state(priv, state); > if (IS_ERR(priv_state)) > diff --git a/drivers/gpu/drm/ingenic/ingenic-ipu.c > b/drivers/gpu/drm/ingenic/ingenic-ipu.c > index > 2574a4b4d40a2c27cb212114117829d9f6ab3ddb..32638a713241abbd4eaed09f0aa > ec2b790650cc9 100644 > --- a/drivers/gpu/drm/ingenic/ingenic-ipu.c > +++ b/drivers/gpu/drm/ingenic/ingenic-ipu.c > @@ -578,11 +578,11 @@ static int > ingenic_ipu_plane_atomic_check(struct drm_plane *plane, > struct ingenic_ipu_private_state *ipu_state; > > if (!crtc) > return 0; > > - crtc_state = drm_atomic_get_existing_crtc_state(state, > crtc); > + crtc_state = drm_atomic_get_new_crtc_state(state, crtc); > if (WARN_ON(!crtc_state)) > return -EINVAL; > > ipu_state = ingenic_ipu_get_priv_state(ipu, state); > if (IS_ERR(ipu_state))
